Show how to patch the asar file

flathub / electron-sample-app

Sample application based on electron

GNU General Public License v3.0

23 stars 11 forks source link

Show how to patch the asar file #15

Open razzeee opened 4 months ago

razzeee commented 4 months ago

See: https://github.com/flathub/com.mattermost.Desktop/pull/124

https://github.com/flathub/com.discordapp.Discord/blob/master/com.discordapp.Discord.json#L67

https://github.com/flathub/org.electronjs.Electron2.BaseApp/blob/branch/23.08/patch-desktop-filename.py

cpba commented 4 months ago

I'm not sure I understand what this is for, could you please explain it a bit further?

razzeee commented 4 months ago

If your electron app doesn't have the correct desktop-entry - as it needs to match the id - notifications will look broken etc.

For e.g. gnome shell tries to get the app icon via the id, and it won't find anything, so it shows the missing/broken icon in notifications with gnome 46. I think unity has a similar behavior when it comes to the message counter on their dock.