flathub / eu.betterbird.Betterbird

https://flathub.org/apps/details/eu.betterbird.Betterbird
6 stars 0 forks source link

fix systray bugs #136

Closed mfschumann closed 7 months ago

mfschumann commented 7 months ago

might fix https://github.com/Betterbird/thunderbird-patches/issues/214

flathubbot commented 7 months ago

Started test build 83787

flathubbot commented 7 months ago

Build 83787 successful To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/66423/eu.betterbird.Betterbird.flatpakref
flathubbot commented 7 months ago

Started test build 83927

flathubbot commented 7 months ago

Build 83927 failed

mfschumann commented 7 months ago

bot, build

flathubbot commented 7 months ago

Queued test build for eu.betterbird.Betterbird.

flathubbot commented 7 months ago

Started test build 83928

flathubbot commented 7 months ago

Build 83928 successful To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/66569/eu.betterbird.Betterbird.flatpakref
flathubbot commented 7 months ago

Started test build 84086

flathubbot commented 7 months ago

Build 84086 successful To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/66725/eu.betterbird.Betterbird.flatpakref
Betterbird commented 7 months ago

Can you please explain these changes. Usually the icons are loaded from chrome/icons/default/ relative to the install directory of the executable. I don't see why the app indicator library would find them in /app/share/icons/hicolor/scalable/status/eu.betterbird.Betterbird-default.svg when called with just eu.betterbird.Betterbird-default, even without file extension.

mfschumann commented 7 months ago

The magic happens when a user installs the flatpak: when the flatpak ships icons in /app/share/icons whose names start with the ID of the flatpak, they are "exported", i.e., they are symlinked into the icon collection on the host. That's where the indicator can find it by icon ID.