flathub / flathub

Issue tracker and new submissions
https://docs.flathub.org/docs/for-app-authors/submission
GNU Lesser General Public License v2.1
1.08k stars 2k forks source link

Add org.fooyin.fooyin #5261

Closed eclipseo closed 1 week ago

eclipseo commented 2 weeks ago

Fooyin

Fooyin is a music player built around customisation. It offers a growing list of widgets to manage and play your local music collection. It's extendable through the use of plugins and scriptable using FooScript.

Features:

Please confirm your submission meets all the criteria

Software author must have co-ownership of the repo if approved: https://github.com/ludouzi/

This is my first Flatpak, any advice is greatly appreciated.

Linting:

flatpak run --command=flatpak-builder-lint org.flatpak.Builder manifest org.fooyin.fooyin.yaml
no error

flatpak run --command=flatpak-builder-lint org.flatpak.Builder appstream org.fooyin.fooyin.metainfo.xml
? Validation was successful.

flatpak run --command=flatpak-builder-lint org.flatpak.Builder repo repo
{
    "errors": [
        "appstream-remote-icon-not-mirrored",
        "appstream-external-screenshot-url"
    ],
    "message": "Please consult the documentation at https://docs.flathub.org/docs/for-app-authors/linter"
}

flatpak run org.fooyin.fooyin
Detected locale "C" with character encoding "ANSI_X3.4-1968", which is not UTF-8.
Qt depends on a UTF-8 locale, and has switched to "C.UTF-8" instead.
If this causes problems, reconfigure your locale. See the locale(1) manual
for more information.
Loaded "qt" translations for locale "en_US" from "/usr/translations"
Failed to load "fooyin" translations for locale "en_US" from "/app/share/fooyin/translations"
Detected locale "C" with character encoding "ANSI_X3.4-1968", which is not UTF-8.
Qt depends on a UTF-8 locale, and has switched to "C.UTF-8" instead.
If this causes problems, reconfigure your locale. See the locale(1) manual
for more information.
Loaded "qt" translations for locale "zh_CN" from "/usr/translations"
Loaded "fooyin" translations for locale "zh_CN" from "/app/share/fooyin/translations"

Translations do work though.

Not sure how to handle the mirroring yet.

hfiguiere commented 2 weeks ago

Not sure how to handle the mirroring yet.

Just remove "remote" icons from the appstream file.

hfiguiere commented 2 weeks ago

bot, build org.fooyin.fooyin

flathubbot commented 2 weeks ago

Queued test build for org.fooyin.fooyin.

flathubbot commented 2 weeks ago

Started test build 121795

hfiguiere commented 2 weeks ago

Not sure how to handle the mirroring yet.

Just remove "remote" icons from the appstream file.

and I don't see any. Let's see what buildbot has to say.

flathubbot commented 2 weeks ago

Build 121795 successful To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/104738/org.fooyin.fooyin.flatpakref
eclipseo commented 2 weeks ago

bot, build org.fooyin.fooyin

flathubbot commented 2 weeks ago

Queued test build for org.fooyin.fooyin.

flathubbot commented 2 weeks ago

Started test build 121815

flathubbot commented 2 weeks ago

Build 121815 successful To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/104758/org.fooyin.fooyin.flatpakref
eclipseo commented 2 weeks ago

Ok, I've tested locally, it works fine.

As said, I don't have any remote icon, so I don't get: appstream-remote-icon-not-mirrored.

I do have an external screenshot, but from what I've understood --mirror-screenshots-url=URL will handle it, right?

bbhtt commented 2 weeks ago

I'm seeing a blank window from second launch

https://github.com/flathub/flathub/assets/62639087/9c1ad71b-8ae3-4d44-b4c9-ff37b457ceee

eclipseo commented 2 weeks ago

bot, build org.fooyin.fooyin

flathubbot commented 2 weeks ago

Queued test build for org.fooyin.fooyin.

eclipseo commented 2 weeks ago

I'm seeing a blank window from second launch Screencast.mp4

I can't reproduce this on Plasma 6. I will need to try with a GNOME system like yours maybe.

eclipseo commented 2 weeks ago

Screenshot_20240519_062555

In the screencast, on your second run, we see the icon of Fooyin in your taskbar.

flathubbot commented 2 weeks ago

Started test build 121903

flathubbot commented 2 weeks ago

Build 121903 successful To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/104847/org.fooyin.fooyin.flatpakref
bbhtt commented 2 weeks ago

In the screencast, on your second run, we see the icon of Fooyin in your taskbar.

But the window is invisible which is the issue. I can only get it back on second launch by rm-ing all app data from ~/.var/app/app-id and launching again so that it is a "fresh" start.

ludouzi commented 1 week ago

I've just tried the latest test build in Gnome 46.1 and it runs fine on subsequent launches, so I'm not sure what's happening in your case. I'll have to do some testing.

eclipseo commented 1 week ago

In the screencast, on your second run, we see the icon of Fooyin in your taskbar.

But the window is invisible which is the issue. I can only get it back on second launch by rm-ing all app data from ~/.var/app/app-id and launching again so that it is a "fresh" start.

What os/GNOME are you using so I can try to repro?

bbhtt commented 1 week ago

It's Fedora 39/GNOME 45 inside GNOME Boxes.

bbhtt commented 1 week ago

Looks like I can't repro on my host running F40

This comment needs to be solved https://github.com/flathub/flathub/pull/5261#discussion_r1605804782

eclipseo commented 1 week ago

Ok I removed the flathub.json

barthalion commented 1 week ago

bot, build org.fooyin.fooyin

flathubbot commented 1 week ago

Queued test build for org.fooyin.fooyin.

flathubbot commented 1 week ago

Started test build 122400

flathubbot commented 1 week ago

Build 122400 successful To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/105341/org.fooyin.fooyin.flatpakref
barthalion commented 1 week ago

/merge

flathubbot commented 1 week ago

A repository for this submission has been created: https://github.com/flathub/org.fooyin.fooyin

You will receive an invitation to be a collaborator which will grant you write access to the repository above. The invite can be also viewed here.

If you've never maintained an app on Flathub before, common questions are answered in the app maintenance guide. If you're the original developer (or an authorized party), verify your app next to let users know it's coming from you.

Thanks!

eclipseo commented 1 week ago

Thank you.