search

flathub / fm.helio.Workstation

https://flathub.org/apps/details/fm.helio.Workstation
1 stars 1 forks source link

Fix plugin scanning #4

Closed jistr closed 1 year ago

jistr commented 1 year ago

During plugin scanning, Helio is launching itself as a child process, and due to perhaps what is a JUCE limitation, it cannot cope with being launched as helio (even though the helio binary is on $PATH). It seems Helio must be launched with an absolute path to the binary for plugin scanning to work.

Broken:

$ flatpak run --command=helio fm.helio.Workstation
Safe scanning: /app/extensions/Plugins/vst3/Dexed.vst3
JUCE Assertion failure in juce_posix_SharedCode.h:1100
Done scanning for audio plugins

$ flatpak run --devel --command=bash fm.helio.Workstation -c 'echo $PATH'
/app/bin:/usr/bin

Working:

$ flatpak run --command=/app/bin/helio fm.helio.Workstation
Safe scanning: /app/extensions/Plugins/vst3/Dexed.vst3
Done scanning for audio plugins

Fixes: https://github.com/flathub/fm.helio.Workstation/issues/1

flathubbot commented 1 year ago

Started test build 68988

flathubbot commented 1 year ago

Build 68988 failed

hfiguiere commented 1 year ago

you should patch JUCE instead. It's just wronng.

For the record this was working previously but I guess it got broken and I didn't realise.

jistr commented 1 year ago

They have some non-OSS licencing so i'll report an issue for them. But i think the flatpak patch here shouldn't hurt either? It could be a long time before this is fixed in JUCE and bubbles through into Helio.

jistr commented 1 year ago

https://github.com/juce-framework/JUCE/issues/1280

hfiguiere commented 1 year ago

When it's broken, it's broken.