search

flathub / im.riot.Riot

https://flathub.org/apps/details/im.riot.Riot
32 stars 43 forks source link

Revert "Revert "Enable text-input-v1 support for Wayland IME under KWin/Weston/Hyprland"" #396

Closed q234rty closed 9 months ago

q234rty commented 9 months ago

Reverts flathub/im.riot.Riot#359

The actual bug has been fixed w/ https://chromium-review.googlesource.com/c/chromium/src/+/4423030 and has been fixed a long time ago. The reason I didn't submit this before is that I have been hitting https://github.com/flathub/im.riot.Riot/issues/381 regardless of whether --enable-wayland-ime is added. However https://github.com/flathub/im.riot.Riot/issues/381 doesn't seem to be reproducible w/ 1.11.41 which seems to be using electron26, and --enable-wayland-ime works just fine.

flathubbot commented 9 months ago

Started test build 65325

flathubbot commented 9 months ago

Build 65325 successful To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/47964/im.riot.Riot.flatpakref
q234rty commented 9 months ago

The test build is now crashing for me, what?

Edit: The "create revert" button on github doesn't seem to rebase the commits...

flathubbot commented 9 months ago

Started test build 65331

flathubbot commented 9 months ago

Build 65331 successful To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/47970/im.riot.Riot.flatpakref
flathubbot commented 9 months ago

Started test build 65336

flathubbot commented 9 months ago

Build 65336 successful To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/47975/im.riot.Riot.flatpakref
q234rty commented 9 months ago

OK the test build seems to be working fine now.

flathubbot commented 9 months ago

Started test build 68581

flathubbot commented 9 months ago

Build 68581 successful To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/51228/im.riot.Riot.flatpakref
flathubbot commented 9 months ago

Started test build 68667

flathubbot commented 9 months ago

Build 68667 successful To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/51311/im.riot.Riot.flatpakref
flathubbot commented 9 months ago

Started test build 69818

flathubbot commented 9 months ago

Build 69818 successful To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/52470/im.riot.Riot.flatpakref
flathubbot commented 9 months ago

Started test build 69859

flathubbot commented 9 months ago

Build 69859 successful To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/52511/im.riot.Riot.flatpakref
SISheogorath commented 9 months ago

If someone who uses it could tell me if the latest build works, I would merge it. Even though I think it's a bit bad that it goes from "needing to dropping to needing".

q234rty commented 9 months ago

@SISheogorath the latest test build works for me.