Notifications cause Element to crash after commit 6d9d107 "Use newer freedesktop platform 23.08"

flathub / im.riot.Riot

https://flathub.org/apps/details/im.riot.Riot

32 stars 43 forks source link

Notifications cause Element to crash after commit 6d9d107 "Use newer freedesktop platform 23.08" #406

Closed aquarichy closed 8 months ago

aquarichy commented 9 months ago

Since recently upgrading my Element flatpak from Flathub, clicking on notifications now causes Element to crash. Using the most recent commit, 4e01ebe0d1b235afdd9cb16d49a0952fd108fb5d, it still crashes.

I went through recent commits of im.riot.Riot and found:

first bad one: 6d9d107941143997e40649192116d93eefe38796 "Use newer freedesktop platform 23.08"
last good one: 228f25ed93158d38be811a92b1f116ec6b73428f (I built local ones using instructions from https://docs.flatpak.org/en/latest/first-build.html)

System:

Fedora Linux 38 (Workstation Edition)
64-bit
GNOME 44.5
kernel: Linux 6.5.5-200.fc38.x86_64
window manager: Wayland

I haven't debugged Flatpaks before so any direction on what I can look at to help find the issue would be great.

I will see if I can debug it further, since updating the platform seems like a big change.

aquarichy commented 9 months ago

Hmm, just experienced this with Signal's flatpak as well.

https://github.com/flathub/org.signal.Signal/issues/521

Someone has created a bug on libnotify for this:

https://gitlab.gnome.org/GNOME/libnotify/-/issues/34 "Signal crashes in flatpak when notification is dismissed"

Where a user notes its impact on Element.

bbhtt commented 8 months ago

Give, 4-5 hours for the baseapp update to be published, then rebuild Element against it via https://buildbot.flathub.org/#/apps/im.riot.Riot. Thanks

@SISheogorath ^

yajo commented 8 months ago

So has anybody triggered this rebuild? It seems easy to fix here, now that it's fixed upstream.

bbhtt commented 8 months ago

Unfortunately, this bug in the linter needs to be fixed before triggering a build https://github.com/flathub/flatpak-builder-lint/issues/183 else it'd fail.

hfiguiere commented 8 months ago

bot, build

bbhtt commented 8 months ago

It's an issue :D Build was triggered here https://buildbot.flathub.org/#/builders/6/builds/72141

bbhtt commented 8 months ago

https://buildbot.flathub.org/#/builders/6/builds/72142, should be published in 4-5 hours

SISheogorath commented 8 months ago

Mhm, decided to speed-run the publishing. (I know, not overly popular among the flathub maintainers, sorry). Updates should be rolling out within the next minutes!

aquarichy commented 8 months ago

The updated Flatpak on Flathub resolves the issue in my testing. Yahoo! Thank you.