search

flathub / im.riot.Riot

https://flathub.org/apps/details/im.riot.Riot
32 stars 43 forks source link

Don't enable Wayland support by default #432

Closed pieterdd closed 4 months ago

pieterdd commented 4 months ago

It's not entirely stable yet. It might be best to let people opt in via Flatseal if they desire for now.

https://github.com/flathub/im.riot.Riot/issues/382#issuecomment-1933290992 https://github.com/element-hq/element-desktop/issues/768 https://github.com/element-hq/element-desktop/issues/873 https://github.com/element-hq/element-desktop/issues/1040

flathubbot commented 4 months ago

Started test build 98492

flathubbot commented 4 months ago

Build 98492 successful To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/81269/im.riot.Riot.flatpakref
SISheogorath commented 4 months ago

After reviewing the mentioned issues, I still don't think Wayland is that unstable.

https://github.com/element-hq/element-desktop/issues/873 <-- is about element-nightly and explicitly stating, that stable (which we distribute here) was not effected https://github.com/element-hq/element-desktop/issues/1040 <-- talks about stable on Debian and was closed in September https://github.com/element-hq/element-desktop/issues/768 <-- Is quite thin on details and open for a year

Remaining https://github.com/flathub/im.riot.Riot/issues/382 which is already closed with the solution that people can manually disable wayland, if it actually causes problems for them. My current impression is that not many people have issues with it.

Since we aim to improve wayland support in Element by driving adoption, which was an explicit decision (https://github.com/flathub/im.riot.Riot/pull/325#issuecomment-1414051581), I don't think we will not disable wayland again.

But feel free to share your thoughts.

pieterdd commented 4 months ago

I agree that migrating to Wayland is a good thing.

For me the Flatpak distribution only works with Wayland support turned off, though. When I started the Flatpak, I had no way to open the chat window. That's how I ended up finding the recommendation to use the X version. I've shared some logs in the closed thread to help diagnose the issue, but the X version satisfies my needs.