search

flathub / im.riot.Riot

https://flathub.org/apps/details/im.riot.Riot
32 stars 43 forks source link

Why --disable-gpu-sandbox? #452

Open t3dium opened 4 weeks ago

t3dium commented 4 weeks ago

Why is this flag being passed, which could potentially reduce security, if users are using wayland with element?

I've just tried using element with wayland, on nvidia, and I haven't encountered any issues despite not disabling the gpu sandbox.

I had a look into this and it appears it's only problematic for webGL?

https://wiki.archlinux.org/title/chromium

If you are using Chromium with Bumblebee, WebGL might crash due to GPU sandboxing. In this case, you can disable GPU sandboxing with optirun chromium --disable-gpu-sandbox.

However, element doesn't even require webGL to my knowledge.

SISheogorath commented 3 weeks ago

The background to the issue can be found here: https://github.com/flathub/im.riot.Riot/issues/234

It was never revisited, it might be resolved by now.

t3dium commented 3 weeks ago

The background to the issue can be found here: #234

It was never revisited, it might be resolved by now.

Yeah it works perfectly fine on wayland now, without needing that fix:

image

SISheogorath commented 3 weeks ago

Uhm, that's probably not that easy given we don't know the original configuration, we don't know which graphics card and which drivers triggered the problem.

We also don't know with which combination it works for you. I'm not saying we can't remove the option but we should get a sample size larger than 1.