flathub / im.riot.Riot

https://flathub.org/apps/details/im.riot.Riot
33 stars 44 forks source link

Window is not resizable in 1.11.80 build #477

Open tomhughes opened 1 week ago

tomhughes commented 1 week ago

I updated to the 1.11.80 build and found the window now appears to have a fixed size (roughly 1200x800) and can't be resized.

Downgrading to the previous build has restored the ability to resize.

I would also note that even the previous version has a weird issue with resizing where it won't let you move an edge too close to the edge of a monitor - it has some sort of buffer strip that it won't allow you to move into. That started happening a couple of months ago.

SISheogorath commented 1 week ago

Is it similar to https://github.com/flathub/im.riot.Riot/issues/332 or is different?

Could you provide some details like your desktop environment along with versions and maybe a screenshot to make the problem more visual?

tomhughes commented 1 week ago

I'm running Fedora 40 with the default Gnome Wayland desktop. The border issue basically comes down to this:

image

which is as close as I can drag any edge of the element window to the edge of the monitor.

In 1.11.80 there are simply no drag handles at all when I hover over the window edge, but only in the flatpak version - if I use the tar ball version that it is resizable as normal.

SISheogorath commented 1 week ago

Mhm, interestingly enough, running the latest Fedora Silverblue 40, I can't reproduce this, but I also can't resize the window (which I usually also don't test before merging) 👀 So something is off.

SISheogorath commented 1 week ago

I think you can probably change window behaviour drastically, when you disable wayland using tools like flatseal.

You can also temporarily test if it fixes the issue using:

flatpak kill im.riot.Riot
flatpak run --nosocket=wayland im.riot.Riot

This also explains, why it's a non-issue with upstream, since upstream doesn't enable wayland by default. You can see we jump through some hops to make it happen in the flatpak:

https://github.com/flathub/im.riot.Riot/blob/d32d14a402665d0c7591a3ff8ce731a1c713a7d1/element.sh#L3-L14

tomhughes commented 1 week ago

The interesting thing is that I also use a (non-flatpak) vs code and I pass --ozone-platform-hint=wayland --enable-features=WaylandWindowDecorations to that to get wayland support and it doesn't have any of these issues.

konomikitten commented 1 week ago

On Debian Unstable under GNOME 47 running with Wayland if I use flatpak run im.riot.Riot --ozone-platform=x11 the problem goes away. If I use flatpak run im.riot.Riot --ozone-platform=wayland --enable-features=WaylandWindowDecorations the problem occurs. My flatpak version of Element is 1.11.81.

Could people please specify their Distro, Desktop Environment and Element versions so we can better understand what circumstances are causing this bug?

tomhughes commented 1 week ago

I can confirm that matches what I see on Fedora 40 with Gnome 46 and Element 1.11.80 or newer.

konomikitten commented 1 week ago

Is this possibly related to https://github.com/electron/electron/issues/43714?