search

flathub / info.portfolio_performance.PortfolioPerformance

https://flathub.org/apps/details/info.portfolio_performance.PortfolioPerformance
8 stars 4 forks source link

Overwrite directory `.eclipse` sandbox security #68

Closed Morpheus1w3 closed 1 year ago

Morpheus1w3 commented 1 year ago

Flatpack require dedicated access for directory .eclipse due to the sandbox update process https://github.com/buchen/portfolio/issues/3418#issuecomment-1606259200

flathubbot commented 1 year ago

Started test build 49565

flathubbot commented 1 year ago

Build 49565 successful To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/32167/info.portfolio_performance.PortfolioPerformance.flatpakref
roshanshariff commented 1 year ago

The flathub.json file is the wrong place for finish-args. It should go in info.portfolio_performance.PortfolioPerformance.json. But if you look there, you'll see that we already have --filesystem=home, which includes ~/.eclipse.

Indeed, the reason you're seeing a ~/.eclipse directory at all is because, by default, we give the Portfolio Performance flatpak access to your home directory. I'm not sure why the PP Flatpak creates/uses that directory if the non-Flatpak version doesn't (according to @buchen in buchen/portfolio#3418). That merits further investigation.