search

flathub / info.portfolio_performance.PortfolioPerformance

https://flathub.org/apps/details/info.portfolio_performance.PortfolioPerformance
8 stars 4 forks source link

Update to version 0.65.4 #89

Closed flathubbot closed 1 year ago

flathubbot commented 1 year ago

Update PortfolioPerformance-0.65.3-linux.gtk.x86_64.tar.gz to 0.65.4 Update PortfolioPerformance-0.65.3-linux.gtk.aarch64.tar.gz to 0.65.4

🤖 This pull request was automatically generated by flathub/flatpak-external-data-checker. Please open an issue if you have any questions or complaints. 🤖

flathubbot commented 1 year ago

Started test build 71649

flathubbot commented 1 year ago

Build 71649 failed

flathubbot commented 1 year ago

Started test build 71706

flathubbot commented 1 year ago

Build 71706 failed

roshanshariff commented 1 year ago

This seems to be blocked on flathub/flatpak-builder-lint#183. We should retry a build when that is fixed.

hfiguiere commented 1 year ago

bot, build

flathubbot commented 1 year ago

Queued test build for info.portfolio_performance.PortfolioPerformance.

flathubbot commented 1 year ago

Started test build 72144

bbhtt commented 1 year ago

Started test build 72144

Seems it is having some issues while debug stripping

stripping /srv/buildbot/worker/build-x86_64/build/.flatpak-builder/rofiles/rofiles-zhthl3/files/jre/bin/plugins/com.sun.jna_5.13.0.v20230812-1000/com/sun/jna/linux-arm/libjnidispatch.so to /srv/buildbot/worker/build-x86_64/build/.flatpak-builder/rofiles/rofiles-zhthl3/files/lib/debug/jre/bin/plugins/com.sun.jna_5.13.0.v20230812-1000/com/sun/jna/linux-arm/libjnidispatch.so.debug
FB: Running: eu-strip --remove-comment --reloc-debug-sections -f /srv/buildbot/worker/build-x86_64/build/.flatpak-builder/rofiles/rofiles-zhthl3/files/lib/debug/jre/bin/plugins/com.sun.jna_5.13.0.v20230812-1000/com/sun/jna/linux-arm/libjnidispatch.so.debug -F /app/lib/debug/jre/bin/plugins/com.sun.jna_5.13.0.v20230812-1000/com/sun/jna/linux-arm/libjnidispatch.so.debug /srv/buildbot/worker/build-x86_64/build/.flatpak-builder/rofiles/rofiles-zhthl3/files/jre/bin/plugins/com.sun.jna_5.13.0.v20230812-1000/com/sun/jna/linux-arm/libjnidispatch.so
debugedit: Failed to update file: invalid section entry size
flathubbot commented 1 year ago

Build 72144 failed

hfiguiere commented 1 year ago

it's try to strip foreign architecture things.

FB: Running: eu-strip --remove-comment --reloc-debug-sections -f /srv/buildbot/worker/build-x86_64/build/.flatpak-builder/rofiles/rofiles-zhthl3/files/lib/debug/jre/bin/plugins/com.sun.jna_5.13.0.v20230812-1000/com/sun/jna/linux-arm/libjnidispatch.so.debug -F /app/lib/debug/jre/bin/plugins/com.sun.jna_5.13.0.v20230812-1000/com/sun/jna/linux-arm/libjnidispatch.so.debug /srv/buildbot/worker/build-x86_64/build/.flatpak-builder/rofiles/rofiles-zhthl3/files/jre/bin/plugins/com.sun.jna_5.13.0.v20230812-1000/com/sun/jna/linux-arm/libjnidispatch.so
bbhtt commented 1 year ago

The PortfolioPerformance-0.65.3-linux.gtk.x86_64/portfolio/plugins/com.sun.jna_5.13.0.jar file in the tarball ships with libraries from both (all) arches, it needs to be cleared somehow. It's trying to generate the debuginfo from that

roshanshariff commented 1 year ago

@hfiguiere @bbhtt Maybe this should be fixed upstream in flatpak builder? The JRE libraries are coming from org.freedesktop.Sdk.Extension.openjdk17, which would need to remove the .so files for other arches. Maybe it's better for the debuginfo extraction to ignore them instead?

bbhtt commented 1 year ago

The JRE libraries are coming from org.freedesktop.Sdk.Extension.openjdk17, which would need to remove the .so files for other arches.

Why would the extension remove anything? It's coming from the application, it shouldn't include libraries for multiple arches for a linux-x86_64 package. Not sure if flatpak-builder can handle this.

You can disable stripping or something like will also "fix" it

"rm -rf $(find plugins/com.sun.jna_5.13.0.v*/com/sun/jna/* -maxdepth 1 -type d -name \"*freebsd*\" -o -name \"*openbsd*\" -o -name \"*sunos*\" -o -name \"*linux*\" -not -path \"*/linux-x86-64\" -not -path \"*/linux-aarch64\")",
bbhtt commented 1 year ago

Also add this to the build-commands:

"mkdir -p ${FLATPAK_DEST}/bin",
"ln -s {FLATPAK_DEST}/jre/bin/PortfolioPerformance ${FLATPAK_DEST}/bin"

and change the command to:

"command": "PortfolioPerformance"

desktop file expects the executable to be in /app/bin, but nothing is placing it there.

roshanshariff commented 1 year ago

@bbhtt, my apologies; I thought those files were coming from the JRE installation, but they are indeed included with the app. I think for now I'm going to disable the debuginfo generation. In any case, it doesn't catch most of the shared objects because they're inside JAR files, so it's probably not that useful for debugging anyway.

@buchen, would you happen to know why most of the libraries in plugins/ are shipped as JAR files, but a few (including com.sun.jna with the latest PP version) are shipped as extracted directories? It happens to include shared libraries for all architectures, from which the builder is trying to extract debug information and failing.

flathubbot commented 1 year ago

Started test build 72223

flathubbot commented 1 year ago

Build 72223 successful To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/54877/info.portfolio_performance.PortfolioPerformance.flatpakref
roshanshariff commented 1 year ago

This version upgrade reintroduces bug #66. I'm holding off on merging it until we decide how to handle that.

flathubbot commented 1 year ago

🤖 This PR passed CI, and automerge-flathubbot-prs is true in flathub.json, so I'm merging it automatically. 🤖

flathubbot commented 1 year ago

🤖 This PR passed CI, and automerge-flathubbot-prs is true in flathub.json, so I'm merging it automatically. 🤖

flathubbot commented 1 year ago

Started test build 72252

flathubbot commented 1 year ago

Build 72252 successful To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/54902/info.portfolio_performance.PortfolioPerformance.flatpakref
roshanshariff commented 1 year ago

For now, I've moved the configuration area to be inside $XDG_RUNTIME_DIR, which is a tmpfs that is guaranteed to be cleared whenever the user's session ends. This seems to avoid #66 at least after a log-out. On my system, the configuration area occupies around 5 MB.

bot, build

flathubbot commented 1 year ago

Queued test build for info.portfolio_performance.PortfolioPerformance.

flathubbot commented 1 year ago

Started test build 72253

flathubbot commented 1 year ago

Build 72253 successful To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/54904/info.portfolio_performance.PortfolioPerformance.flatpakref
roshanshariff commented 1 year ago

Creating a new pull request because buildbot isn't updating the checks on this one, despite successful builds.