search

flathub / io.conduktor.Conduktor

https://flathub.org/apps/details/io.conduktor.Conduktor
3 stars 0 forks source link

Flathub bot missing updates #59

Closed Eonfge closed 2 years ago

Eonfge commented 2 years ago

@barthalion Sorry for bothering you with your busy schedule, but the Bot has not been keeping up with releases for Conduktor. Is everything working out alright on your end?

Eonfge commented 2 years ago

@sderosiaux Perhaps you can also help us in this case? Are you (Copnduktor Inc.) oke with it, if Flathub starts to directly distribute file data?

Right now we use a two-stage system so that we can 'bypass' some distribution restrictions. If you can approve us distributing it directly, then that can help us both.

sderosiaux commented 2 years ago

Hey @Eonfge! Do you have documentation around this, for me to get a clear view of what will happen? Flathub can distribute the files, just need to know how this will work exactly, ensuring there is no loophole.

Eonfge commented 2 years ago

Hey,

Most of the details can be found here:

As for a loophole, you'll have to explain what you're concerned about. Are you concerned about the security of your users?

Flatpak uses GIT for much of it's administration: Projects that are on Flatpak have there version and changes tracked in this. With this, it's relatively easy to manually rebuild a package at any time. I previously wrote about that.

As for the individual file integrity, Flatpak uses libostree so that it only distributes mutations, and that it does so in an atomic and reliable way: You can't break the application by aborting an update or by losing internet. Updates are also automatically pushed to users, so they won't be stuck on unsupported versions.

[kevin@kevin-fedora-desktop ~]$ flatpak info io.conduktor.Conduktor 

Conduktor - A beautiful and fully-featured desktop client for Apache Kafka

          ID: io.conduktor.Conduktor
         Ref: app/io.conduktor.Conduktor/x86_64/stable
        Arch: x86_64
      Branch: stable
     Version: 2.20.3
     License: LicenseRef-proprietary
      Origin: flathub
  Collection: org.flathub.Stable
Installation: system
   Installed: 166,7 MB
     Runtime: org.freedesktop.Platform/x86_64/21.08
         Sdk: org.freedesktop.Sdk/x86_64/21.08

      Commit: 67439859ed6507812d6e3f77dbab92652d9f3ecb0cac1e5bfcb1c3e674b1cf84
      Parent: e1977517b79b8c4522158bd3d18cd84e0dd8df1597448b2b36bbb63778161499
     Subject: Update conduktor.zip (bb06ca0c)
        Date: 2022-04-20 17:51:00 +0000

It even shows you a history of all versions

[kevin@kevin-fedora-desktop ~]$ flatpak remote-info --log flathub io.conduktor.Conduktor
        ID: io.conduktor.Conduktor
       Ref: app/io.conduktor.Conduktor/x86_64/stable
      Arch: x86_64
    Branch: stable
Collection: org.flathub.Stable
  Download: 56,1 MB
 Installed: 166,7 MB
   Runtime: org.freedesktop.Platform/x86_64/21.08
       Sdk: org.freedesktop.Sdk/x86_64/21.08

    Commit: 67439859ed6507812d6e3f77dbab92652d9f3ecb0cac1e5bfcb1c3e674b1cf84
    Parent: e1977517b79b8c4522158bd3d18cd84e0dd8df1597448b2b36bbb63778161499
   Subject: Update conduktor.zip (bb06ca0c)
      Date: 2022-04-20 17:51:00 +0000
   History: 

    Commit: e1977517b79b8c4522158bd3d18cd84e0dd8df1597448b2b36bbb63778161499
   Subject: Update conduktor.zip (0633e8d2)
      Date: 2022-04-19 09:36:14 +0000

    Commit: e6310fe984b21591cc23fbb7f5db7801e7b17507cebe27287c58c38f2eb98d7a
   Subject: Update conduktor.zip (07ab54be)
      Date: 2022-04-07 11:39:15 +0000
[...]

Feel free to ask. I gladly help you further

barthalion commented 2 years ago

@Eonfge You can go through https://github.com/flathub/flathub/actions/workflows/external-data-checker.yml to find matching run and see what happened. That being said, I would assume there could have been no change or something?

@sderosiaux The difference is that we would use our CDN to distribute "flatpak-ready" Conduktor, meaning it would be extracted first on our build infra and repackaged into flatpak. Currently it uses the extra-data mechanism, which causes Flatpak to download Conduktor from your infrastructure and apply any needed changes locally on the users' computers.

sderosiaux commented 2 years ago

OK, thank you both. That makes sense and seems like a better option.

I guess not but I prefer to ask: No impact for users? Nothing to change on their side for users who already have Conduktor installed?

barthalion commented 2 years ago

Yeah, no changes for the users.

Eonfge commented 2 years ago

It would actually work better for users. If you look at #58, that issue is caused because of a mismatch between Flathub and Conduktor. Right now, once you publish an update it takes a few hours before Flathubbot has it processed... in those few hours users can't install Conduktor.

Once we fully integrate, users can directly download Conduktor and the update will then be available to them within an hour.

sderosiaux commented 2 years ago

OK interesting. Wonderful then!

Eonfge commented 2 years ago

Made a pull-request for you to test and approve; https://github.com/flathub/io.conduktor.Conduktor/pull/60

Eonfge commented 2 years ago

The initial release went perfect. I do have one thing to fix in relation to the rotating URLs, so I'll look into that: https://github.com/flathub/io.conduktor.Conduktor/pull/61

Eonfge commented 2 years ago

Well. Think we got it all finished up. Package should now auto-update and distribute the update to all users. About 1200 in total, so that's not bad.

sderosiaux commented 2 years ago

Impressive indeed! Thanks a lot for your work @Eonfge. Note that we're going to do another release probably tomorrow. 🤞

Eonfge commented 2 years ago

Everything worked perfectly. I kept an eye on it today, and the update was quickly picked up. A few hours later, the update was on the CDN servers and users only had to download a few MB to get the update.

sderosiaux commented 2 years ago

Marvellous 🚀

On Fri 13 May 2022 at 16:06, Eonfge @.***> wrote:

Everything worked perfectly. I kept an eye on it today, and the update was quickly picked up. A few hours later, the update was on the CDN servers and users only had to download a few MB to get the update.

— Reply to this email directly, view it on GitHub https://github.com/flathub/io.conduktor.Conduktor/issues/59#issuecomment-1126094384, or unsubscribe https://github.com/notifications/unsubscribe-auth/AA6BBS5KSX2JLYBNJ4LDBM3VJZOWRANCNFSM5VORVZ3A . You are receiving this because you were mentioned.Message ID: <flathub/io. @.***>

-- -Stéphane