search

flathub / io.conduktor.Conduktor

https://flathub.org/apps/details/io.conduktor.Conduktor
3 stars 0 forks source link

Do not rely on our website to fetch Desktop version #73

Closed sderosiaux closed 2 years ago

sderosiaux commented 2 years ago

@Eonfge would that work like this?

flathubbot commented 2 years ago

Started test build 106791

flathubbot commented 2 years ago

Build 106791 successful To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/104468/io.conduktor.Conduktor.flatpakref
flathubbot commented 2 years ago

Started test build 106792

flathubbot commented 2 years ago

Build 106792 successful To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/104469/io.conduktor.Conduktor.flatpakref
Eonfge commented 2 years ago

Yes, it seems like this is perfect!

If I run it on the unchanged manifest, nothing happens:

[kevin@kevin-fedora-desktop ~/Projects/io.conduktor.Conduktor]$ flatpak run org.flathub.flatpak-external-data-checker io.conduktor.Conduktor.yaml
INFO    src.manifest: Checking 1 external data items
INFO    src.manifest: Started check [1/1] archive conduktor/conduktor.zip (from io.conduktor.Conduktor.yaml)
INFO    src.manifest: Finished check [1/1] archive conduktor/conduktor.zip (from io.conduktor.Conduktor.yaml)
INFO    src.main: Check finished with 0 error(s)

But when I then change the version number, it picks it up right away:

[kevin@kevin-fedora-desktop ~/Projects/io.conduktor.Conduktor]$ flatpak run org.flathub.flatpak-external-data-checker io.conduktor.Conduktor.yaml
INFO    src.manifest: Checking 1 external data items
INFO    src.manifest: Started check [1/1] archive conduktor/conduktor.zip (from io.conduktor.Conduktor.yaml)
INFO    src.lib.externaldata: Source conduktor.zip: got new version 2.23.2
INFO    src.manifest: Finished check [1/1] archive conduktor/conduktor.zip (from io.conduktor.Conduktor.yaml)
OUTDATED: conduktor.zip
 Has a new version:
  URL:       https://releases.conduktor.io/linux-zip?placeholder=2.23.2
  MD5:       df1014f3af5de3ecbc47990991732edf
  SHA1:      493b0c5c3faa1fcddc39dcbdb15812718b1a698d
  SHA256:    19ebd418a486a8c54a4a681913a39ed5cb19d792a4db7d93224df1f5f668577b
  SHA512:    19b7183190bd585aa815d0135a69653063c4bfc8fd8ff4d6883ae2dea45bbb6e50c0959499f8a89416b00c980a9c14bc67c858dd0e0e08e4dcf82be84d005b5b
  Size:      276644688
  Version:   2.23.2
  Timestamp: 2022-08-16 20:24:04

INFO    src.main: Check finished with 0 error(s)

So yes. Let's add this! I can't actually remember if you always had versioned downloads... perhaps that would have been easier from the start.

Eonfge commented 2 years ago

Tool to check the manifests dependencies is on flathub; https://github.com/flathub/flatpak-external-data-checker

Some dogfooding that really helps