flathub / io.freetubeapp.FreeTube

https://flathub.org/apps/details/io.freetubeapp.FreeTube
15 stars 10 forks source link

Remove broad `--socket=session-bus` access #65

Closed bbhtt closed 2 years ago

bbhtt commented 2 years ago

Fixes https://github.com/flathub/io.freetubeapp.FreeTube/issues/64 but needs some testing.

Hi, @PrestonN if you have time please review. Thank you!

flathubbot commented 2 years ago

Started test build 76156

flathubbot commented 2 years ago

Build 76156 successful To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/74023/io.freetubeapp.FreeTube.flatpakref
flathubbot commented 2 years ago

Started test build 76198

flathubbot commented 2 years ago

Build 76198 successful To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/74067/io.freetubeapp.FreeTube.flatpakref
flathubbot commented 2 years ago

Started test build 94178

flathubbot commented 2 years ago

Build 94178 failed

bbhtt commented 2 years ago

Build 94178 failed

Build fails as appstream validation fails due to wrong width and height in the appdata:

• attribute-invalid     : <screenshot> width (1567) did not match specified (1920) [https://raw.githubusercontent.com/FreeTubeApp/FreeTubeApp.io/master/src/images/FreeTube1.png]
• attribute-invalid     : <screenshot> height (1079) did not match specified (1016) [https://raw.githubusercontent.com/FreeTubeApp/FreeTubeApp.io/master/src/images/FreeTube1.png]
• attribute-invalid     : <screenshot> width (1567) did not match specified (1920) [https://raw.githubusercontent.com/FreeTubeApp/FreeTubeApp.io/master/src/images/FreeTube4.png]
• attribute-invalid     : <screenshot> height (1079) did not match specified (1013) [https://raw.githubusercontent.com/FreeTubeApp/FreeTubeApp.io/master/src/images/FreeTube4.png]
• attribute-invalid     : <screenshot> width (1567) did not match specified (1920) [https://raw.githubusercontent.com/FreeTubeApp/FreeTubeApp.io/master/src/images/FreeTube2.png]
• attribute-invalid     : <screenshot> height (1079) did not match specified (1017) [https://raw.githubusercontent.com/FreeTubeApp/FreeTubeApp.io/master/src/images/FreeTube2.png]
Validation of files failed

I've opened https://github.com/flathub/io.freetubeapp.FreeTube/pull/71 for that. It needs to be merged first to make the pipeline happy.

bbhtt commented 2 years ago

bot, build

flathubbot commented 2 years ago

Queued test build for io.freetubeapp.FreeTube.

flathubbot commented 2 years ago

Started test build 102073

flathubbot commented 2 years ago

Build 102073 failed

flathubbot commented 2 years ago

Started test build 102075

flathubbot commented 2 years ago

Started test build 102076

flathubbot commented 2 years ago

Build 102075 successful To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/99786/io.freetubeapp.FreeTube.flatpakref
flathubbot commented 2 years ago

Build 102076 successful To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/99787/io.freetubeapp.FreeTube.flatpakref
flathubbot commented 2 years ago

Started test build 102281

flathubbot commented 2 years ago

Build 102281 successful To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/99992/io.freetubeapp.FreeTube.flatpakref
TingPing commented 2 years ago

Thanks!