Update runtime to 22.08

bbhtt commented 2 years ago

There are some graphical corruption issues with FDO 21.08, Electron applications are primarily affected https://gitlab.com/freedesktop-sdk/freedesktop-sdk/-/issues/1460. Not sure if Freetube is specifically affected.

Also better to use newer runtime if it works :)

flathubbot commented 2 years ago

Started test build 112402

flathubbot commented 2 years ago

Build 112402 successful To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/110010/io.freetubeapp.FreeTube.flatpakref

bbhtt commented 2 years ago

Seems to work

bbhtt commented 2 years ago

With the recent news about mesa 22.2 dropping support by default for patented codecs, maybe it'd be good to have this on 21.08 runtime where the mesa version is frozen, that is until a decision is made on FDO level https://gitlab.com/freedesktop-sdk/freedesktop-sdk/-/issues/1494

The 22.08 runtime already has mesa 22.2 and the next rebuild of the runtime will make the drop.

flathubbot commented 2 years ago

Started test build 4649

flathubbot commented 2 years ago

Build 4649 successful To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/117095/io.freetubeapp.FreeTube.flatpakref

pm4rcin commented 1 year ago

Since there's a Mesa Extra package installed by default I guess we can merge that.

bbhtt commented 1 year ago

cc @PrestonN

StrangestNoob commented 1 year ago

tested with 22.08 and it fixes the artifacting without any issues cc @PrestonN

bbhtt commented 1 year ago

Hi, @efb4f5ff-1298-471a-8973-3d47447115dc Since @PrestonN is inactive and the current runtime will reach EOL by the end of August 2023, do you have any objections if I merge this?

absidue commented 1 year ago

As far as I'm aware, merging a pull request in this repository triggers new flatpak builds resulting in people getting notified of new changes, even though nothing changed from the FreeTube side. That's why we haven't merged any pull requests in here, as there hasn't been a FreeTube release in a while, as notifying people of updates when there is no noticeable change or changelog is undesirable.

efb4f5ff-1298-471a-8973-3d47447115dc commented 1 year ago

Hi @bbhtt

@PrestonN mentioned that we should only merge stuff in the flathub repo close to a release, as it triggers a new flatpak build and notifies everyone of a new release, even if nothing changed from the FreeTube side.

We are very close to doing a release hopefully no longer than 2 weeks and i will mention this to look over this repo when we are ready.

Is it possible to wait a couple of weeks or do you think this is so urgent that it cant wait?

bbhtt commented 1 year ago

Hi @bbhtt

@PrestonN mentioned that we should only merge stuff in the flathub repo close to a release, as it triggers a new flatpak build and notifies everyone of a new release, even if nothing changed from the FreeTube side.

Not sure what Preston meant but upgrading runtime/dependencies doesn't cause a "release" notification. People will just see that the app has an update and that it switched to a newer runtime in flatpak update/GNOME Software etc.

The build is done on Flathub infra and in general dependency/runtime updates will require rebuilds while keeping the base app on the same version. This is fine to do.

Unless github actions on the freetube repo is hooked somehow to show release notifications? I see that Freetube version upgrades here are automated through the actions bot.

We are very close to doing a release hopefully no longer than 2 weeks and i will mention this to look over this repo when we are ready.

Is it possible to wait a couple of weeks or do you think this is so urgent that it cant wait?

Yea, it's fine for a few weeks more.

absidue commented 1 year ago

@bbhtt Will it be made obvious to users that the only change was on the flatpak side? How do you handle the version number not changing?

absidue commented 1 year ago

Would be nice for our users not to get confused about there not being a changelog from the FreeTube side.

P.S. In case you hadn't already noticed I'm one of the FreeTube devs

bbhtt commented 1 year ago

@bbhtt Will it be made obvious to users that the only change was on the flatpak side? How do you handle the version number not changing?

The website https://flathub.org/apps/io.freetubeapp.FreeTube will show the same version of Freetube, as will any frontend like GNOME software/KDE discover and in the flatpak cli

The version is derived from the appdata file, in the release tag which is bumped only when Freetube version changes.

https://github.com/flathub/io.freetubeapp.FreeTube/blob/master/io.freetubeapp.FreeTube.metainfo.xml#L52

absidue commented 1 year ago

Feel free to get this merged then (don't think I have those rights here as this is a flathub repo, not one that is part of the FreeTube GitHub org).

bbhtt commented 1 year ago

bot, build

Can you test the below build?