flathub / io.github.RodZill4.Material-Maker

https://flathub.org/apps/details/io.github.RodZill4.Material-Maker
5 stars 4 forks source link

Lack of EXR support #9

Open schrottkatze opened 1 year ago

schrottkatze commented 1 year ago

Hello, the MM flatpak is still unable to export to exr, which, especially if you're working with blender, is quite a significant problem. Apparently, the problem seems to be something with the godot that material maker uses being customized, but I don't know the details of that.

I hope that will eventually be fixed, since the lack of exr exports is a quite significant problem.

Thanks!

Calinou commented 1 year ago

EXR support is only available in editor builds (not export templates), so this requires packaging an editor build to run the Material Maker PCK instead. That said, this is not the most optimized approach in terms of binary size. Instead, building a custom export template (patched to enable openexr module in non-editor builds) will be more efficient.

We could also just use the official Material Maker binary directly, but Flathub discourages using precompiled binaries for open source software.

All of these approaches will result in dropping the Godot BaseApp anyway, which means the binary will have to be duplicated with other Flatpaks that use it.

Feel free to look into this, as I won't have time to tackle it in the near future. I recommend going with the patched export template route (see the BaseApp's build manifest for reference).

schrottkatze commented 1 year ago

Flathub discourages using precompiled binaries for open source software.

I'd guess that it's worse if a feature (especially one that's quite important) of the application doesn't work due to using the baseapp.

The duplication probably isn't the worst issue since there's (to my knowledge) not a lot of godot apps anyway, and most people won't care.

I don't think I'd be very successful since my godot knowledge is pretty much limited to starting godot and pressing the "run" button.