search

flathub / io.github.celluloid_player.Celluloid

https://flathub.org/apps/details/io.github.celluloid_player.Celluloid
3 stars 12 forks source link

Add read-only access to xdg-config/mpv #108

Closed stove-panini closed 11 months ago

stove-panini commented 1 year ago

This adds read-only access to xdg-config/mpv as it relates to the settings in "Preferences > Config Files" which directly reference mpv.

flathubbot commented 1 year ago

Started test build 28942

flathubbot commented 1 year ago

Build 28942 successful To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/11609/io.github.celluloid_player.Celluloid.flatpakref
TingPing commented 1 year ago

I'm not sure I like this.

We bundle our own MPV version, what it supports is completely independent from whats on the host. If you want to configure this version of MPV you make a configuration file for it.

stove-panini commented 1 year ago

I chose ~/.config/mpv/ because that's the config directory used by plain mpv. Just so I understand, you're saying that it's not easy for the user to know the supported features of the bundled mpv, so it should not share a config directory with a separate installation of mpv?

What would you suggest to make this section of the preferences more usable? Currently, it can only read from ~/Pictures.

TingPing commented 1 year ago

you're saying that it's not easy for the user to know the supported features of the bundled mpv, so it should not share a config directory with a separate installation of mpv?

Yes. Even if a user knows this means it conflicts with a host package.

What would you suggest to make this section of the preferences more usable? Currently, it can only read from ~/Pictures.

This seems like a Celluloid bug. The file chooser there should be using the portal and be able to choose any path.