flathub / io.github.celluloid_player.Celluloid

https://flathub.org/apps/details/io.github.celluloid_player.Celluloid
3 stars 12 forks source link

Dark theme not applied #131

Closed secretmango closed 9 months ago

secretmango commented 9 months ago

The app follows the system Theme, the "enable dark theme button" only affects the black bottom bar. It would be cool if the app could just not follow the system theme at all? The top bar is huge and very bright.

Can you show me what access I can disable to make the app either not see the systems GTK theme (this works on KDE too) or preset the dark theme actively?

I could not find an issue about that specifically.

I am using KDE Plasma which applies the Plasma theme to a GTK something theme too. Celluloid follows the Plasmatheme which I set to light.

secretmango commented 9 months ago

I found the solution:

in KDE Flatpak settings under "Environment" I add this parameter:

GTK_THEME

Adwaita:dark

Celluloid now uses the dark theme no matter what system theme I use!

So the "use dark theme" switch in the Settings should use this parameter somehow, as Celluloid follows the GTK theme

TingPing commented 9 months ago

Generally do not set GTK_THEME, it is a development setting. Though it is one way to set a theme for a specific app.

To set dark mode: gsettings set org.gnome.desktop.interface color-scheme prefer-dark

secretmango commented 9 months ago

does this work when just setting it per-app? Because I only want it in the videoplayer, and as there is a setting in its settings I imagine this could be intended behavior

TingPing commented 9 months ago

The GTK_THEME way is the only per-app way.

Just to clarify, the core of the problem here is your active theme doesn't have a dark variant. So you are forcing a single app to use a different theme with a dark variant.

secretmango commented 9 months ago

okay interesting! I am on KDE which automatically adapt the "default" theme to the currently used variant.

I must have changed that, Celluloid does accept that theme.