search

flathub / io.github.foldynl.QLog

https://flathub.org/apps/details/io.github.foldynl.QLog
0 stars 2 forks source link

Broken LoTW Service - external TrustedQSL call #5

Closed foldynl closed 1 year ago

foldynl commented 1 year ago

@AsciiWolf unfortunately I found another issue. It is based on the QLog design, where an external TrustedQSL (tqsl) binary is directly called for signing and sending to LoTW. Each user can have the TrustedQSL binary installed elsewhere, therefore QLog allow to define the path to this binary. And that, as I unfortunately found out, is a big issue in flatpak world because of the sandbox (binary is moved to sandbox when it is selected in the application but without libraries). The result is that the defined binary cannot be executed.

I don't know what the correct solution is. It would probably be best to stop providing QLog via flathub (if it is possible). To be honest, QLog wasn't designed for sandboxing, so I don't know now how many similar things will still be there.

Another option is to keep QLog in Flathub, but I don't see how to call an external TrustedQSL from QLog, because there are two options how TrustedQSL can be installed 1) TrustedQSL is installed as a binary on the host filesystem. 2) TrustedQSL is also flatpak

Both variants have to be resolved.

Any idea how to fix it?

AsciiWolf commented 1 year ago

Hi Ladislav, thanks for reporting this! Considering all the time and effort already put into this Flatpak, it would be really pity to remove it from Flathub just because one feature (that is not used by all users) is not available.

Instead, I suggest the following:

  1. Put a warning in the description section of AppStream metadata that LoTW is currently not available in the Flatpak version of QLog.
  2. Try to integrate TrustedQSL into the Flatpak. Here is a Flatpak manifest of TrustedQSL. It looks fairly simple, the only dependency it adds is wxWidgets. (While we could also consider using the existing TrustedQSL Flatpak - it should be possible - I would not recommend it since it could be problematic. Integrating tqsl directly into the QLog Flatpak is more reliable.)
foldynl commented 1 year ago
  1. Put a warning in the description section of AppStream metadata that LoTW is currently not available in the Flatpak version of QLog.

Currently, this is under the development

  1. Try to integrate TrustedQSL into the Flatpak. Here is a Flatpak manifest of TrustedQSL. It looks fairly simple, the only dependency it adds is wxWidgets. (While we could also consider using the existing TrustedQSL Flatpak - it should be possible - I would not recommend it since it could be problematic. Integrating tqsl directly into the QLog Flatpak is more reliable.)

No sure if it is easy task to integrate it. It is necessary to keep in mind that the certificate management will be performed by an external flatpak tqsl (or installed tqsl from OS), but the internal tqsl (in QLog flatpak) must have access to this certificate in home directory. This means that it must be resolved (maybe changing QLog's filesystem to home?).