The update button doesn't work

[AsciiWolf]

Clicking the "Check for Updates" button causes the game to crash on free(): invalid pointer error. Updating the Flatpak version this way is not supported anyway so it could be a good idea to try disabling the button. Unfortunately, it's a part of the game data pk3 that is included in the data package, not in the compiled source, so writing a patch for this won't be easy.

[TingPing]

Surely other distros dealt with this problem already like Debian?

[AsciiWolf]

As far as I know, all distros that have Tremulous packaged use the older 1.2 version that doesn't have this button.

[dGr8LookinSparky]

I'm still very new to flatpak. But this bug may be occurring from not copying over the granger binary. granger is basically a helper binary that is a part of the update system, it is also a part of the lua system (that is involved in the execution of lua scripts in the client's console). You may also want to copy over the contents of the scripts/ folder.

Somewhat off-topic question, but are the default maps and default data pk3 files copied over to where they need to be sufficiently? Also what about the tremded (dedicated server) binary?

[dGr8LookinSparky]

Oh, as an additional comment about the current built-in update system (outside of flatpak), at the moment it does let you know in the main menu when we have a new release, and shows a description in the main menu of the changes in the latest release, but at the moment the actual updating process isn't yet functional, but that might not be very important to the use of flatpack anyways.

[AsciiWolf]

Thanks for your answer! You are right, I am not copying the granger binary or the scripts folder. It worked fine without it so I did not copy these files. But yeah, auto updates won't work inside the Flatpak anyway, unfortunately I was not able to disable the Check for Updates button. :(

[dGr8LookinSparky]

Since the actual updating feature isn't functional currently anyways, and it only provides information in the client about new updates being available, I don't think there would be issues with flatpak currently by just copying those over now. But when we do get the update to be fully functional, we could include a build option to disable that part of it for distribution systems like flatpak.

The other thing, as I mentioned, the granger binary is important for running the current lua support, which is one of the cool additional features the client has (that is you can run lua scripts right from the client console, and do various interesting things that you couldn't do with just binds).

[AsciiWolf]

Ah, thanks for the info! I have created a RFE issue for the Lua support and will add it when I have some free time. :-)

[AsciiWolf]

I have added the granger binary and scripts directory, unfortunately the update function still causes Tremulous to crash on free(): invalid pointer.

[dGr8LookinSparky]

Which file and line does that crash occur in?

[AsciiWolf]

I don't know. This is the only thing that was printed on stdout.

[dGr8LookinSparky]

To clarify, does the crash occur when you click on the Check for Updates button of the main menu, and not another button that might show after when the updates menu pops up?

[AsciiWolf]

It occurs when I click on the Check for Updates button.

[AsciiWolf]

I found out that it crashes as well if I click the "News" button. New window with the "Retrieving..." text is displayed, then game crashes. Same error. :-(