Support LADSPA plugins - Githubissues

hfiguiere commented 4 years ago

This PR is blocked by flathub/flathub#1504 that provide the swh plugins as a flatpak.

This PR add support for LADSPA plugins a flatpak.

It defines the LADSPA Plugins extension point
It tell to auto install swh
it doesn't build swh anymore.

What I tested:

Build without no swh and no extension point, no audio filter. (explicit message)
Build with the extension points added, the audio filters are there

Caveat: I also have CMT and TAP installed and I can't get them to show up in Flowblade. (it work in other apps)

Let me know if you have questions.

Also added a patch that pin the flowblade git checkout to the tag instead of an unsupported mix of branch and commit. It is not required for this though.

flathubbot commented 4 years ago

Started test build 20024

flathubbot commented 4 years ago

Build 20024 successful To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/19207/io.github.jliljebl.Flowblade.flatpakref

jliljebl commented 4 years ago

Both changes seem correct from here, thank you. merging.

hfiguiere commented 4 years ago

I said this was blocked by flathub/flathub#1504. So now Flowblade WILL lack swh as the package still hasn't landed.

:-/

jliljebl commented 4 years ago

Ok, well, the Ladspa plugins were not working on Flowblade Flatpak 2.4 so we did not lose any functionality. I'll try to somehow get LADSPA plugins for 2.6, lets see what happens.

hfiguiere commented 4 years ago

fair enough. I was just worried about losing functionality for the users.

swh plugins do appear though when they are installed by either method.

flathub / io.github.jliljebl.Flowblade

Support LADSPA plugins #12