search

flathub / io.gitlab.librewolf-community

https://flathub.org/apps/details/io.gitlab.librewolf-community
15 stars 11 forks source link

From JSON to YAML, fixed GlobalMenu support. #80

Closed xplshn closed 11 months ago

xplshn commented 11 months ago

That's it, fixed GlobalMenu support, and updated the recipe from JSON to YAML, also, I added -O3 and -pipe for better performance, and -pipe for faster compilation.

In any case, if you don't want YAML, or the -O3 -pipe flags, please, implement the fix for GlobalMenu(The patch and GTK settings.ini).

Please test before merging, I can't compile Firefox in my hardware(No GPU, laptop with an i3 of 7th gen, and just 4GB of RAM)

xplshn commented 11 months ago

bot, build

flathubbot commented 11 months ago

Queued test build for io.gitlab.librewolf-community.

flathubbot commented 11 months ago

Started test build 82659

flathubbot commented 11 months ago

Build 82659 failed

lsfxz commented 11 months ago

First off: thanks for your PR!

While YAML-ifying the JSON, and the addition to gtk-settings.ini are in the right place in this repo here, the (re-)inclusion of the menubar patch (same way it would be with the kde patches, if those were supposed to be added back) would have to be proposed upstream though (at https://codeberg.org/librewolf/source) – mainly for two reasons: the flatpak (mostly) build just "repackages" the upstream binary artifacts anyway – the main LibreWolf build process happens there. also, a while ago these patches might have caused some issues, and even after those didn't crop up anymore for a bit, the patches were (IIRC) nevertheless dropped because it was considered an additional maintenance burden (ie. having to wait for ubuntu / opensuse to provide updated patches; update them on earch release, etc.). That doesn't mean we wouldn't potentially (re-)introduce them again – just that it needs to be discussed upstream :)