flathub / io.mrarm.mcpelauncher

https://flathub.org/apps/details/io.mrarm.mcpelauncher
25 stars 5 forks source link

Minecraft classic skin import #34

Open killerkalamari opened 3 years ago

killerkalamari commented 3 years ago

Steps to Reproduce: Profile > Edit Character > 2nd tab (Classic Skins) > Owned > Import > Choose New Skin

Currently: Does nothing

Enhancement Request: Pop up a file browser to select a skin png. Or, alternatively, if I need to give the skin file a specific filename and manually move it somewhere under /var/lib/flatpak/app/io.mrarm.mcpelauncher/ that works too.

Thanks!

EDIT Workaround:

  1. Go here: https://github.com/ChristopherHX/linux-packaging-scripts/releases
  2. Download the AppImage for your CPU. Note that the latest x86_64 is currently here: https://github.com/ChristopherHX/linux-packaging-scripts/releases/tag/v0.1-beta-21-648
  3. chmod +x the AppImage file
  4. Run it
  5. Choose Minecraft 1.16.201, because the Profile settings in 210 seem to be broken
  6. Sign in to Microsoft account
  7. Profile > Edit Character > 2nd tab (Classic Skins) > Owned > Import > Choose New Skin
  8. It pops up a file dialog and works!
ChristopherHX commented 3 years ago

For me, gnome desktop, it works in the flatpak too. I heard in the past it somehow don't work with some setups

I don't know what to do about this, flatpak specfic side effect.

Does this command open a file picker on your system? If not it is a flatpak (runtime) bug.

flatpak run --command=zenity io.mrarm.mcpelauncher --file-selection
killerkalamari commented 3 years ago

You're correct, I get an error:

$ flatpak run --command=zenity io.mrarm.mcpelauncher --file-selection

(zenity:2): Gtk-WARNING **: 12:30:20.168: Can't open portal file chooser: GDBus.Error:org.freedesktop.DBus.Error.UnknownMethod: No such interface 'org.freedesktop.portal.FileChooser' on object at path /org/freedesktop/portal/desktop

I'm using Ubuntu 18.04 (I need to upgrade) and MATE 1.20. That error is all over the web, but the common suggested fix of installing the packages xdg-desktop-portal-gtk and/or xdg-desktop-portal-kde, didn't fix it. I noticed that those reporting errors were on earlier versions of Ubuntu (and it seems to have gone away with Ubuntu 20.04), so it's probably relying on a newer library or such.

To be honest, now that I know how to use the AppImage files, that seems to work fine. In fact, I think I like it even better, as I'd only installed the flatpak stuff for Minecraft, but the AppImage works without the extra baggage. IMO, anyone else who runs into this should just forget the flatpak and use the AppImage.