flathub / io.qt.qtwebengine.BaseApp

9 stars 13 forks source link

Add 6.5 branch #196

Closed JakobDev closed 1 year ago

JakobDev commented 1 year ago

This tries to add a 6.5 branch. I have edited the patch files local with a text editor (I don't know how to properly update them), so they don't throw a error any more., but I have no Idea what they do and I can't tell, if that was done right. I can't even say if this this even builds. If this builds and works, this needs to be merged in a new branch.

flathubbot commented 1 year ago

Started test build 49226

flathubbot commented 1 year ago

Build 49226 failed

JakobDev commented 1 year ago

QtWebEngine will not be built: Unmodified ffmpeg >= 5.0 is not supported.

Does that mean I need to include a older ffmpeg version?

flathubbot commented 1 year ago

Started test build 49236

flathubbot commented 1 year ago

Build 49236 successful To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/31835/io.qt.qtwebengine.BaseApp.flatpakref
JakobDev commented 1 year ago

Is there anything still prevent this from being merged?

tsdgeos commented 1 year ago

Is there anything still prevent this from being merged?

Nobody has said yes to my "Anyhow i think "internal ffmpeg is used" is good enough, if -DQT_FEATURE_webengine_system_ffmpeg=OFF does that no opposition from my side." yet.

Or i missed it ^_^

Erick555 commented 1 year ago

yes, -DQT_FEATURE_webengine_system_ffmpeg=OFF enables internal ffmpeg.

tsdgeos commented 1 year ago

"I can't even say if this this even builds"

"Is there anything still prevent this from being merged?"

This is giving me a bit of conflicting information. Have you confirmed this at least builds or have you not? If you have not, what's preventing you to do it?

JakobDev commented 1 year ago

This is giving me a bit of conflicting information. Have you confirmed this at least builds or have you not?

It works. The buildbot has made a successfully testbuild. Did you miss the comment?

tsdgeos commented 1 year ago

Ok, i was hoping for something more than "it compiles" but i guess we could start with that...

I just realized i can't commit here though :D

hfiguiere commented 1 year ago

let me create the branch then.

hfiguiere commented 1 year ago

Branch created.