search

flathub / io.qt.qtwebengine.BaseApp

9 stars 13 forks source link

Update qtwebengine to v5.15.16-lts (branch/5.15-23.08) #325

Closed bbhtt closed 7 months ago

bbhtt commented 7 months ago

See https://github.com/flathub/io.qt.qtwebengine.BaseApp/pull/324

flathubbot commented 7 months ago

Started test build 82236

flathubbot commented 7 months ago

Build 82236 was cancelled

flathubbot commented 7 months ago

Started test build 82245

flathubbot commented 7 months ago

Build 82245 failed

flathubbot commented 7 months ago

Started test build 83181

flathubbot commented 7 months ago

Build 83181 successful To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/65816/io.qt.qtwebengine.BaseApp.flatpakref
AsciiWolf commented 7 months ago

It looks like that this issue is still happening on the 5.15-23.08 branch.

bbhtt commented 7 months ago

It looks like that this issue is still happening on the 5.15-23.08 branch.

what issue?

AsciiWolf commented 7 months ago

Sorry, I meant the flathub-json-skip-appstream-check one that looks to be caused by this base app (and should have been fixed by one of this PR's commits). See this build log: https://buildbot.flathub.org/#/builders/6/builds/83603

bbhtt commented 7 months ago

Sorry, I meant the flathub-json-skip-appstream-check one that looks to be caused by this base app (and should have been fixed by one of this PR's commits). See this build log: https://buildbot.flathub.org/#/builders/6/builds/83603

That fixes it for this baseapp only, but now flathub.json from the baseapp is coming into the app and skip-appstream-check isn't allowed for regular apps. You should something like this to clean it up in apps:

    {
        "name": "cleanup-flathub-json",
        "buildsystem": "simple",
        "build-commands": [
            "rm -rvf ${FLATPAK_DEST}/flathub.json"
        ]
    }
  - name: cleanup-flathub-json
    buildsystem: simple
    build-commands:
      - rm -rvf ${FLATPAK_DEST}/flathub.json

This is temporary. See the discussion here https://github.com/flathub/flathub/issues/4693#issuecomment-1825983345

AsciiWolf commented 7 months ago

Ah, thanks for the info! :-)