search

flathub / io.typora.Typora

https://flathub.org/apps/details/io.typora.Typora
3 stars 5 forks source link

Internet access #3

Closed maresmar closed 3 years ago

maresmar commented 3 years ago

Thank you for providing a nice way how to use and update Typora!

I often add online images to my markdown documents. Sadly it doesn't work now because Typora doesn't have Internet access.

Internet access would also help the following features to work properly:

syco commented 3 years ago

Access was restricted as a consequence of this ticket: https://github.com/syco/io.typora.flatpak/issues/3 I personally don't have anything against network access, but I'm not sure what to do now.. can't make everyone happy..

bilelmoussaoui commented 3 years ago

Access was restricted as a consequence of this ticket: https://github.com/syco/io.typora.flatpak/issues/3 I personally don't have anything against network access, but I'm not sure what to do now.. can't make everyone happy..

Simple: if a permission is needed for the application to properly work. Keep it. If someone wants to remove it, they can do so on their machine.

syco commented 3 years ago

I agree with that.. What about the pulseaudio permission? Is that needed by any other functionality?

andypillip commented 3 years ago

Just wanted to add that you cannot install type check languages without internet connection either.

Typora allows embedding video and audio in documents, so I guess these would need sound to work?

Btw Fedora is changing away from Pulse to Pipewire this month, to somehow allow for audio in Flatpak (I don't know the specifics). No idea if this is relevant to the discussion.

Have a great one!

syco commented 3 years ago

I don't see anything in flatpak for pipewire, might come up at a later stage, for now I've added those permissions for network and audio back (https://github.com/flathub/io.typora.Typora/commit/721e9e2babed5d1554d21e5d052c919ad5afba9d)