flathub / md.obsidian.Obsidian

https://flathub.org/apps/details/md.obsidian.Obsidian
54 stars 14 forks source link

Fix Fcitx5 IME issue with KDE Plasma when running natively under Wayland. #335

Closed 5l2 closed 5 months ago

5l2 commented 5 months ago

I recently noticed that Fcitx5 IME doesn't work with some electron-based applications when running natively under Wayland.

After some research, it turns out that this is an electron problem that can be solved with the --enable-wayland-ime option.

See also: https://forum.obsidian.md/t/ime-fcitx-doesnt-work-when-wayland-is-enabled/79941

flathubbot commented 5 months ago

Started test build 130444

flathubbot commented 5 months ago

Build 130444 successful To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/113434/md.obsidian.Obsidian.flatpakref
joshua-stone commented 5 months ago

@5l2 Thanks for starting this merge request!

I tried using this with the recent Obsidian update, however it didn't seem to work with the Anthy input method I typically use in Gnome Shell for inserting Japanese characters.

Can you test this change with the new update, and can you document in the README what input methods work?

https://github.com/flathub/md.obsidian.Obsidian/blob/master/README.md#wayland-support

5l2 commented 5 months ago

@joshua-stone Of course. Let me study what happened.

flathubbot commented 5 months ago

Started test build 130593

flathubbot commented 5 months ago

Build 130593 successful To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/113583/md.obsidian.Obsidian.flatpakref
flathubbot commented 5 months ago

Started test build 130595

flathubbot commented 5 months ago

Build 130595 successful To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/113585/md.obsidian.Obsidian.flatpakref
flathubbot commented 5 months ago

Started test build 130597

flathubbot commented 5 months ago

Build 130597 successful To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/113587/md.obsidian.Obsidian.flatpakref
5l2 commented 5 months ago

Emm, weird with ibus.

5l2 commented 5 months ago

The issue of ibus IME not working under native wayland has not been resolved in my attempts. It seems that the issue needs to be addressed by GNOME or Electron. However, at least fcitx5 with KDE works fine under native wayland now. I will remove the --gtk-version=4 option and update the documentation. See also:

flathubbot commented 5 months ago

Started test build 130624

flathubbot commented 5 months ago

Build 130624 successful To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/113614/md.obsidian.Obsidian.flatpakref
5l2 commented 5 months ago

All done. Ping @joshua-stone Could you please review it again?

joshua-stone commented 5 months ago

@5l2 Thanks for documenting. This looks good to me.