flathub / net.ankiweb.Anki

https://flathub.org/apps/details/net.ankiweb.Anki
20 stars 13 forks source link

Update runtime to 23.08 #113

Closed Zishan-Rahman closed 8 months ago

flathubbot commented 9 months ago

Started test build 72042

flathubbot commented 9 months ago

Build 72042 failed

Zishan-Rahman commented 9 months ago
    "warnings": [
        "finish-args-contains-both-x11-and-wayland"
    ]

Looks like I'll need to add an exception to flatpak-builder-lint for this app.

Zishan-Rahman commented 9 months ago
    "warnings": [
        "finish-args-contains-both-x11-and-wayland"
    ]

Looks like I'll need to add an exception to flatpak-builder-lint for this app.

Looks like I won't need to do that, because there's a bug in flatpak-builder-lint that's causing this error: flathub/flatpak-builder-lint#183

Once that's fixed, I'll have the test Flatpak rebuilt, and, hopefully, the test build should succeed.

hfiguiere commented 9 months ago

bot, build

flathubbot commented 9 months ago

Queued test build for net.ankiweb.Anki.

hfiguiere commented 9 months ago

what's the justification for having both?

flathubbot commented 9 months ago

Started test build 72143

flathubbot commented 9 months ago

Build 72143 successful To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/54799/net.ankiweb.Anki.flatpakref
Zishan-Rahman commented 9 months ago

what's the justification for having both?

@hfiguiere The Qt6 version of Anki (used for this Flatpak) comes with support for both X11 and Wayland. Better Wayland support is even listed as an advantage of the Qt6 version over the Qt5 version in the docs. The use of Wayland can even be enforced by setting, to 1, a variable called ANKI_WAYLAND upon running the application (it is not enforced by default). Allowing Anki access to both the x11 and wayland sockets should allow it to use a specific windowing system when it is required (in my case, I'm using X11 with Linux Mint 21.2 Cinnamon).

hfiguiere commented 9 months ago

then you should disable wayland if it doesn't work out of the box. otherwise that's what 'fallback-x11' is for.

Zishan-Rahman commented 9 months ago

bot, build

flathubbot commented 9 months ago

Queued test build for net.ankiweb.Anki.

flathubbot commented 9 months ago

Started test build 72181

flathubbot commented 9 months ago

Build 72181 successful To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/54835/net.ankiweb.Anki.flatpakref
Zishan-Rahman commented 8 months ago

then you should disable wayland if it doesn't work out of the box. otherwise that's what 'fallback-x11' is for.

@hfiguiere (sorry for the ping) I just took out the X11 socket from finish-args and used fallback-x11 instead, as per your suggestion. Hopefully this should be good to go now :+1:

rayes0 commented 8 months ago

bot, build

flathubbot commented 8 months ago

Queued test build for net.ankiweb.Anki.

flathubbot commented 8 months ago

Started test build 73764

flathubbot commented 8 months ago

Build 73764 successful To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/56411/net.ankiweb.Anki.flatpakref