search

flathub / net.ankiweb.Anki

https://flathub.org/apps/details/net.ankiweb.Anki
20 stars 13 forks source link

Update Anki to 2.1.44, update dependencies, add LaTeX support #47

Closed ingemarberg closed 3 years ago

ingemarberg commented 3 years ago

This pull request updates Anki, mpv and libass to their most recent version. It also adds support for LaTeX using the Flatpak extension org.freedesktop.Sdk.Extension.texlive, which should close #39.

flathubbot commented 3 years ago

Started test build 52719

flathubbot commented 3 years ago

Build 52719 successful To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/50703/net.ankiweb.Anki.flatpakref
flathubbot commented 3 years ago

Started test build 52734

flathubbot commented 3 years ago

Build 52734 successful To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/50717/net.ankiweb.Anki.flatpakref
laolux commented 3 years ago

Works well for me. LaTeX now works, too, thanks a lot for that!

dsd commented 3 years ago

Thank you. Please feel free to apply to become a maintainer if you would like to push such updates directly in future.

ingemarberg commented 3 years ago

Thanks for merging my pull request, @dsd! I could probably help maintain the Anki Flatpak for the time being. Where would I apply? I've looked at the Flathub documentation but couldn't find something that mentioned this.

dsd commented 3 years ago

@nedrichards Hi, could you please add ingemarberg as an additional maintainer of this flatpak. Thanks

kowalcj0 commented 3 years ago

Hi @ingemarberg , Adding texlive dependency means that flatpak Anki users have to apparently download an additional 4.3GB package. See https://github.com/flathub/org.freedesktop.Sdk.Extension.texlive/issues/51 Is that necessary? Thanks

hfiguiere commented 3 years ago

You could add no-autodownload: true to the add-extension property this would make it optional.

ingemarberg commented 3 years ago

I agree that adding no-autodownload: true would be a better solution, especially since there might be many users that have no need for this extension. Somehow I assumed this would be the default case. Thanks for pointing out my mistake. I've made a new pull request that should fix this.

ingemarberg commented 3 years ago

@kowalcj0 - This should be fixed in #48. I've tried installing the test build and org.freedesktop.Sdk.Extension.texlive is not downloaded automatically anymore. I don't have write access so I can't merge it myself.

@hfiguiere - Thanks for letting me know how this could be resolved!

Thanks once again for pointing out my mistake. I'm still very new to contributing to open source, so I'm sorry I didn't catch this before making my first pull request.

hfiguiere commented 3 years ago

It was easier than actually argue why the flatpak is 4.3GB when upstream is ~4GB.