flathub / net.jami.Jami

https://flathub.org/apps/details/net.jami.Jami
GNU General Public License v3.0
7 stars 7 forks source link

autoreconf -fvi #60

Closed H5117 closed 1 year ago

H5117 commented 1 year ago

Hi! I see in the jami-daemon.yml:29 the command autoreconf -fvi for initialization of autotools. What is it for, if the daemon is built with meson?

FuchtelJockel commented 1 year ago

jami-daemon depends on a heavily patched version of ffmpeg and pjproject. They get build using it's custom build script because I don't see a need or a will to maintain all these patches in the flathub repo. This bootstrap script uses autotools and autoreconf -fvi regenerates all platform depended configurations with files provided by the SDK. This makes autotools aware of the SDK file system. Also see:

man autoreconf
       -v, --verbose
              verbosely report processing

       -f, --force
              consider all generated and standard files obsolete

       -i, --install
              copy missing standard auxiliary files
H5117 commented 1 year ago

I am aware of this, but building of ffmpeg and pjproject is initialized by the bootstrap only. autoreconf -fvi does not affect it. So I think you can safely remove this line. As an example, see Arch Linux build script.

FuchtelJockel commented 1 year ago

will look into it