flathub / net.lutris.Lutris

https://flathub.org/apps/details/net.lutris.Lutris
127 stars 25 forks source link

League of Legends installer - missing zenity #182

Closed ghost closed 2 years ago

ghost commented 3 years ago

Describe the problem While trying to install League of Legends using standard installe from Lutris site, it shows "The installer requires zenity on your system" error and can't proceed. Installing zenity as a standard package results in the same error.

Is it reproducible with native Lutris? No. Steps to reproduce

  1. Install Lutris according to instructions in github main page
  2. Try to install League of Legends from Lutris site

Expected behavior Installer works, gets on with installation.

Actual behavior Installer complains about zenity not installed and then it's blank, can't proceed with installation.

Flatpak info flatpak --version Flatpak 1.10.3 flatpak --gl-drivers default host

anthonytzvetkov commented 2 years ago

PLEASE FIX I CAN'T PLAY LOL LINUX MINT

A6GibKm commented 2 years ago

This project bundles zenity, I suggest you to try bundling it an make a PR, the truth is that I cannot test such a PR as I dont have a LoL account but if you provide it, and some testing is done ill be happy to include it.

MinmoTech commented 2 years ago

I might try to do this if I have some time this weekend

A6GibKm commented 2 years ago

199 includes zenity can anyone test it?

ppGodel commented 2 years ago

i can confirm is not working

DEBUG 2022-01-07 21:24:13,818 [http.get:81]:GET https://lutris.net/api/installers/league-of-legends DEBUG 2022-01-07 21:24:14,201 [application.show_window:259]:Showing window <class 'lutris.gui.installerwindow.InstallerWindow'>league-of-legends DEBUG 2022-01-07 21:24:15,743 [displayconfig.get_current_resolution:624]:Retrieving current resolution ERROR 2022-01-07 21:24:15,744 [errors.init:18]:This installer requires zenity on your system

ppGodel commented 2 years ago

@A6GibKm the library is needed at game instalation, you dont need a lol account to test it.

ppGodel commented 2 years ago

i tried to build the flatpak but it throw me this error:

$ flatpak remote-add --user flathub-beta https://flathub.org/beta-repo/flathub-beta.flatpakrepo flatpak update --appstream error: Remote flathub-beta already exists Updating appstream data for remote fedora Updating appstream data for remote flathub Updating appstream data for user remote flathub-beta $ flatpak-builder --repo=lutris --force-clean --install-deps-from=flathub-beta --user build-dir net.lutris.Lutris.yml Dependency Sdk: org.gnome.Sdk 41 Installing org.gnome.Sdk/x86_64/41 from flathub-beta error: Nothing matches org.gnome.Sdk in remote flathub-beta Error installing deps: running flatpak --user install -y --noninteractive flathub-beta org.gnome.Sdk/x86_64/41: Child process exited with code 1

TheNamelessWonderer commented 2 years ago

Is the lutris package in the beta repo not being updated with new builds?

A6GibKm commented 2 years ago

flatpak-builder --repo=lutris --force-clean --install-deps-from=flathub-beta --user build-dir net.lutris.Lutris.yml

You are going to run into trouble if you ask your deps to come from flathub-beta.

A6GibKm commented 2 years ago

Is the lutris package in the beta repo not being updated with new builds?

It is updated regularly.

A6GibKm commented 2 years ago

I am getting

/usr/lib/python3.9/site-packages/gi/overrides/GObject.py:493: Warning: ../gobject/gsignal.c:2731: instance '0x5654de67ca40' has no handler with id '40328'
  return func(*args, **kwargs)

there is a signal thats being disconnected and does not exist, or was already disconnected...

Note that the wine prefix is being created, but then is deleted (?)

ghost commented 2 years ago

So I guess I should close the issue now? Installer works fine (for me at least), though you still need to compile flatpak yourself and remove modify_ldt sandbox option so you can actually play the game.

strycore commented 2 years ago

Yes, it seems the zenity specific issue is solved