flathub / net.lutris.Lutris

https://flathub.org/apps/details/net.lutris.Lutris
123 stars 24 forks source link

Flatpak missing xdelta3 when using Lutris site installer #246

Open FilBot3 opened 2 years ago

FilBot3 commented 2 years ago

I attempted to click the + button in the top left-hand corner. Then I clicked Search the Lutris website for installers. Then I searched for a game like Genshin Impact and attempted to run it. I then got this error.

image

Is this something that will be needed in the Flatpak in the future? Something called xdelta3?

strycore commented 2 years ago

The simplest solution is to ship xdelta in the Flatpak. It doesn't require modifying the client like providing it through the runtime would. My take is that everything we ship in the runtime should also be shipped in the Flatpak so that we can eventually only rely on the Flatpak and ditch the runtime entirely.

WasteOfO2 commented 2 years ago

Not all distros ship packages like xdelta by default, some even have different names on other distros, installing it is no big deal on the native lutris. although, there isnt really any other choice

going on and continuously adding runtimes may turn time consuming and would rely solely on user input

strycore commented 2 years ago

going on and continuously adding runtimes may turn time consuming and would rely solely on user input

The current lutris runtime (outside of Flatpak) was also relying on user input but also any change had a chance to break on some distros. Adding stuff to the Flatpak looks pretty painless in comparison and assures a working environment for everyone and every game.

WasteOfO2 commented 2 years ago

I was not actually involved in the process of how Lutris came to support such things, thanks for the insight

But from what I have experienced, it was mostly just sudo dnf install .. the missing library and it just worked, atleast for the case of xterm(smth additional needed for Genshin to work) and xdelta

I def would want to contribute making things better, I will look for resources, thanks!

strycore commented 2 years ago

The dnf / apt / pacman solution has worked so far to workaround missing dependencies in Lutris. With Flatpak, this is no longer a possibility so we'll have to ship everything bundled. In the end, having every dependency documented would benefit everyone, including non-Flatpak users.

FilBot3 commented 2 years ago

I wonder if it's possible to ship these dependencies as "Lutris Extensions" similar to how Sdk.Extensions work, or the Steam Compatibility packs work for Proton. Instead of bundling every single library needed for things, it could be an extra Flatpak. That might get cumbersome in of itself as well.

strycore commented 2 years ago

"Lutris extensions" are not something that exists. Nor do we have any plans to make them exist in the future.

NightHammer1000 commented 2 years ago

The manuall install over package manager is nice and all. But not a Solution for Devices with ReadOnly System Partions like the Steam Deck. The Deck would require a reinstall of xdelta after every single Steam Update because user installed Packages get wiped. We dont even beginn to speak of the Issues that arise by unlocking the System Partition.

So yeah. A diffrent, entirely in flatpak contained solution would be needed.

strycore commented 2 years ago

Reminder that programs in Flatpaks are not able to see the software installed on the host system. If Lutris wants to use xdelta3, it must be included in the Flatpak. Having xdelta3 installed on the host system makes no difference at all.