Update to 21.08 runtime and improve build configuration

flathub / net.pcsx2.PCSX2

https://flathub.org/apps/details/net.pcsx2.PCSX2

12 stars 11 forks source link

Update to 21.08 runtime and improve build configuration #33

Closed gal20 closed 3 years ago

gal20 commented 3 years ago

This PR includes several improvements:

Update modules and add x-checker-data for automatic updating
Build with cmake-ninja instead of autotools when possible
Remove some remnants of 32-bit configuration: --allow=multiarch and add-extensions are not needed.
Update runtime to 21.08

flathubbot commented 3 years ago

Started test build 61898

flathubbot commented 3 years ago

Build 61898 failed

flathubbot commented 3 years ago

Started test build 61921

flathubbot commented 3 years ago

Build 61921 successful To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/59750/net.pcsx2.PCSX2.flatpakref

gal20 commented 3 years ago

The previous build had issue with fetching PCSX2 submodules. This issue was not present in the flatpak-builder provided by my package manager (1.0.14). I was able to reproduce the issue with the flatpak-builder hosted on flathub, (1.1.2), so it could be a regression. The issue is solved by adding "disable-shallow-clone": true

j8r commented 3 years ago

On my side I had to do the several changes:

https://gitlab.com/soundtouch/soundtouch.git required a login, so changed to https://codeberg.org/soundtouch/soundtouch - I think the developer moved the repository.
I got a certificate error due to cloning glu, I to change the URL at shared-modules/glu/glu-9.json to https://gitlab.freedesktop.org/mesa/glu/-/archive/glu-9.0.2/glu-glu-9.0.2.tar.gz (and the hash too). By the way, the submodule can be updated (git submodule update --remote --merge)
PCSX2 commit can be bumped again. They are making pre-releases now, may be better to use this tags, at least on the net.pcsx2.PCSX2.metainfo.xml file instead of v1.7.0-dev (see https://github.com/PCSX2/pcsx2/releases)

Other than that, I compiled and worked. The built directory also seems clean, good job!

j8r commented 3 years ago

@gal20 have you still the time, or I can make a PR if you wish so @TingPing can review it?

flathubbot commented 3 years ago

Started test build 66846

flathubbot commented 3 years ago

Build 66846 failed

flathubbot commented 3 years ago

Started test build 66848

flathubbot commented 3 years ago

Build 66848 successful To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/64674/net.pcsx2.PCSX2.flatpakref

gal20 commented 3 years ago

@j8r thanks for the review, I have added your changes

TiZ-HugLife commented 3 years ago

https://gitlab.com/soundtouch/soundtouch.git required a login, so changed to https://codeberg.org/soundtouch/soundtouch - I think the developer moved the repository.

I ran into this when attempting to switch Quod Libet and Ex Falso to FD.O runtime. They did indeed move the repo.

j8r commented 3 years ago

Thanks for the merge @TingPing! https://github.com/flathub/net.pcsx2.PCSX2/issues/30 can now be closed :slightly_smiling_face: