search

flathub / net.puddletag.puddletag

https://flathub.org/apps/details/net.puddletag.puddletag
0 stars 1 forks source link

Enable user files access by default #14

Open SamuXzX opened 1 month ago

SamuXzX commented 1 month ago

I come from this issue: https://github.com/puddletag/puddletag/issues/923#issuecomment-2241325564 It seems that the Flatpak version of Puddletag doesn't have access to user's files: it starts showing Music and Downloads folders. I suppose this is a specific choice, but wouldn't it be more comfortable to see all user's files by default?

I found myself not being able to see my files, given that I don't keep my library in Downloads nor in Music.

eylenburg commented 1 month ago

Hi, that's a valid complaint. The reason I didn't do it yet is that one of the arguments for Flatpaks is the sandboxing and the "guidance" is to give a Flatpak as little privileges and file access as needed. Which I thought for a music tagging app would be the Music folder and maybe the download folder. Other folders I could add are downloads, pictures, and videos, for example. But if I add the whole home folder, this would mean in theory that the app can access and change sensitive files like your .bashrc.

In the meantime, you can change this in KDE Settings -> Applications -> Flatpak permission settings

I had have a look what similar apps are doing: Only Music & Download folders: Easytag Kid3 EarTag Whole /home folder: Musicbrainz Picard Tagger

So I think there's no clear consensus.

Personally, I am indifferent but would slightly lean towards giving it /home-access, because otherwise people might think it's a bug and a Flatpak app should "just work". I think I'll change it with the next update.

SamuXzX commented 1 month ago

Is there no way to split to give permission on /home only to choose the folder, or to filter which folders/files the app can access to?