Please remove usages of branch property from manifests

[bbhtt]

https://github.com/flathub/net.rpcs3.RPCS3/blob/5d1bfdeb2df279f22304888c7e896cc6f51f3661/net.rpcs3.RPCS3.yaml#L90

should be tag or commit or tag+commit

[Lctrs]

Can't. RPCS3 is a rolling release software and we want to be always on top of the master branch.

[bbhtt]

Flathub is not for nightlies to update on every commit. Use the tags, branch is blocked in the linter.

[j8r]

I guess we can use that: https://github.com/RPCS3/rpcs3/releases. Some projects prefer rolling-releases, which seems to fit them well. If the developers and users are happy, that's the most important.

Edit:

Please note that our version increases are landmarks and not stable builds Always download the latest build from https://rpcs3.net/download

@Lctrs is right, we should use master for this project - that's what developers officially recommend.

[j8r]

By the way @bbhtt, thank you to have warned us - I'll make a PR. However, that's not really us packagers to convince to change upstream development model, we just deal with what we are given :slightly_smiling_face:

[j8r]

@Lctrs I see two options:

• we move from the "git" to the "archive" source and still use FEDC, because from what I see at https://github.com/flathub-infra/flatpak-external-data-checker a git source needs a tag.
• or, we use a GitHub Actions cron to update each day to the latest commit by pushing to master (not sure if it still work)

[Lctrs]

@bbhtt that's why we use a custom github actions to run fedc once a day, to not overflow the flathub's build infra on every upstream commit.

@j8r seems like github's archives source do not include git submodules, which only left us with the second option.

[bbhtt]

@bbhtt that's why we use a custom github actions to run fedc once a day, to not overflow the flathub's build infra on every upstream commit.

That does not help, the build still happens on the infra just multiple times a day. What makes it special that you have to update on each commit?

[bbhtt]

Ok seems I misunderstood the setup here, updating once per day is fine. I'll add an exception for this.

Please don't try to increase the frequency of the action.

[bbhtt]

Added an exception. Restart the build in a couple of hours.

Note that it doesn't solve the main issue of branch and commit in the manifest going out of sync and the build from the merge commit silently failing and the update failing to deploy.

The linter won't be able to catch that because of the exception. I assume this is fine, since you really want to update on each commit.