Update to 4.2.0

[porras]

Hi! I'm not exactly a flatpak expert (first time twiddling around) but this Works In My Machine (tm) (Fedora 37).

I also fixed the indentation (which was somehow mixing spaces and tabs) but I did it in a separate commit to make the review easier (although using the UI option to hide whitespace changes also works I guess). I'm adding comments about each of the changes, in the diff.

[flathubbot]

Started test build 112095

[hfiguiere]

See #12 if you can fix it.

[porras]

@hfiguiere I see you got further than me, but still hit the wall :sob:

[hfiguiere]

using obscures platforms lead to that kind of brick wall.

[flathubbot]

Build 112095 failed

[flathubbot]

Started test build 112951

[porras]

I just pushed something that seems to work in my machine (and without --share=network). I followed an approach slightly different to #12. Instead of bypassing the vcpkg and hex tools (after seeing it would be a lot of work) I decided to keep using them, but previously download the files and place them in the cache directories where those tools expect to find them. Of course creating the list of files to download is quite tedious, so I created two simple scripts that do it. They are not needed at build time, but I added them in the PR as documentation (and to reuse them for future releases). After a bit of back and forth, it got to successfully build :)

There are a couple of questionable things that are probably not good flatpak practice:

• It downloads two binary distributions from their repos (vcpkg-glibc and rebar3)
• There is a binary file added in the repo (it's not really binary, it's some kind of erlang specific serialization format) generated in my local machine (containing the list of cached dependencies)

The first one can be probably worked around and get to build those from source. The second I wasn't able to get rid of (although I know almost nothing about erlang/elixir tools, and it might be possible). mix wouldn't see the cache files if this file is not there :(

There are still some things I want to cleanup (and also upgrade erlang, ruby, and the rest of sonic pi dependencies, which is not required but nice I guess) but I wanted to push this to 1) get the bot to test it and 2) get your feedback @hfiguiere. I'd appreciate it!

[flathubbot]

Build 112951 failed

[porras]

@hfiguiere thanks for the quick feedback! I'll see how I can deal with those issues.

Sonic Pi is a super cool project, but it's proving to be... challenging to package, with its mix of platforms. I have zero experience with this kind of environments and platforms (personally I have only worked with dynamic languages, which have their own challenges, but they're quite different).

[flathubbot]

Started test build 113134

[porras]

@hfiguiere it's still work in progress but thanks for the quick look. I rebased on your #12 since you had already dealt with the C++ stuff so it was a bit silly that I would also do it.

I still need to translates the scripts into python, and improve some other couple of things.

[flathubbot]

Build 113134 successful To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/110739/net.sonic_pi.SonicPi.flatpakref

[flathubbot]

Started test build 113241

[flathubbot]

Build 113241 successful To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/110843/net.sonic_pi.SonicPi.flatpakref

[flathubbot]

Started test build 113245

[flathubbot]

Build 113245 successful To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/110847/net.sonic_pi.SonicPi.flatpakref

[porras]

shouldn't this also add the cache.ets entry since it's part of the artifacts? (instead of having it in the main manifest)

That makes sense, I'll do that as soon as I'm back on a computer (it'll be in some days).

Other than that, is this fit to merge?

[flathubbot]

Started test build 113758

[flathubbot]

Build 113758 successful To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/111365/net.sonic_pi.SonicPi.flatpakref

[hfiguiere]

bot, build

[flathubbot]

Queued test build for net.sonic_pi.SonicPi.

[flathubbot]

Started test build 1379

[flathubbot]

Build 1379 successful To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/113831/net.sonic_pi.SonicPi.flatpakref

[hfiguiere]

I'll merge this. Thanks!

Close #12

[porras]

I'll merge this. Thanks!

No, thanks to you!

The build of the merge seems to have failed in one of the architectures due to what I'd say it's a network issue (fetching the screenshot). Maybe someone can retrigger it, or will it be retried? https://buildbot.flathub.org/#/apps/net.sonic_pi.SonicPi

[hfiguiere]

I'll retrigger.

I also have a 22.08 runtime update in the pipe, and 4.3 release.

[hfiguiere]

btw do you want to be comaintainer of this flatpak?

[porras]

Sure, I'll be happy to do that. I guess it involves keeping track of upstream releases and updating the flatpak, taking care of possible issues. What this PR does (and which should be easier in the coming releases).

The build failed again, this time both :disappointed:

flatpak run --env=G_DEBUG=fatal-criticals --command=appstream-util org.flatpak.Builder validate builddir/*/share/appdata/net.sonic_pi.SonicPi.appdata.xml
 in dir /srv/buildbot/worker/build-x86_64-7/build (timeout 1200 secs)
 watching logfiles {}
 argv: b'flatpak run --env=G_DEBUG=fatal-criticals --command=appstream-util org.flatpak.Builder validate builddir/*/share/appdata/net.sonic_pi.SonicPi.appdata.xml'
 using PTY: False
builddir/files/share/appdata/net.sonic_pi.SonicPi.appdata.xml: FAILED:
• url-not-found         : <screenshot> url not valid [https://sonic-pi.net/media/images/tutorial/GUI.png]: Resolving timed out after 5000 milliseconds
Validation of files failed
program finished with exit code 1
elapsedTime=22.703965

It's just trying to fetch this image, which from my side loads without problem. I have no idea what the problem might be.

[hfiguiere]

@barthalion can you invite Sergio ( @porras ) ? Thanks.

[barthalion]

I've just sent an invite to @porras.

[porras]

Thanks!