flathub / net.veloren.veloren

https://flathub.org/apps/details/net.veloren.veloren
9 stars 9 forks source link

Failing to build with #9

Closed BryanQuigley closed 3 years ago

BryanQuigley commented 3 years ago
 Compiling specs v0.16.1 (https://github.com/amethyst/specs.git?rev=d4435bdf496cf322c74886ca09dd8795984919b4#d4435bdf)
   Compiling auth-common v0.1.0 (https://gitlab.com/veloren/auth.git?rev=bffb5181a35c19ddfd33ee0b4aedba741aafb68d#bffb5181)
error[E0075]: SIMD vector length must be a power of two
    --> /run/build/veloren/cargo/vendor/vek/src/vec.rs:2857:13
     |
2857 |               pub struct Vec3<T> { pub x:T, pub y:T, pub z:T }
     |               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
...
3249 | /     vec_impl_all_vecs!{
3250 | |         simd
3251 | |         #[repr(simd)]
3252 | |     }
     | |_____- in this macro invocation
     |
     = note: this error originates in a macro (in Nightly builds, run with -Z macro-backtrace for more info)

   Compiling gilrs-core v0.2.6
error[E0075]: SIMD vector length must be a power of two
    --> /run/build/veloren/cargo/vendor/vek/src/vec.rs:3076:13
     |
3076 |               pub struct Extent3<T> { pub w:T, pub h:T, pub d:T }
     |               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
...
3249 | /     vec_impl_all_vecs!{
3250 | |         simd
3251 | |         #[repr(simd)]
3252 | |     }
     | |_____- in this macro invocation
     |
     = note: this error originates in a macro (in Nightly builds, run with -Z macro-backtrace for more info)

error[E0075]: SIMD vector length must be a power of two
    --> /run/build/veloren/cargo/vendor/vek/src/vec.rs:3166:13
     |
3166 |               pub struct Rgb<T> { pub r:T, pub g:T, pub b:T }
     |               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
...
3249 | /     vec_impl_all_vecs!{
3250 | |         simd
3251 | |         #[repr(simd)]
3252 | |     }
     | |_____- in this macro invocation
     |
     = note: this error originates in a macro (in Nightly builds, run with -Z macro-backtrace for more info)

   Compiling smithay-clipboard v0.6.1
   Compiling smithay-clipboard v0.5.2
   Compiling assets_manager v0.4.2
   Compiling cranelift-codegen-meta v0.68.0
error: aborting due to 3 previous errors

For more information about this error, try `rustc --explain E0075`.
error: could not compile `vek`

To learn more, run the command again with --verbose.
warning: build failed, waiting for other jobs to finish...
error: build failed
Error: module veloren: Child process exited with code 101

My current guess is veloren's build depends on vek 0.11.2 and 0.12.0, but the flatpak only downloads 0.11.2. I can reproduce the flatpak issue locally - but my "pure" git build of veloren works fine.

gasinvein commented 3 years ago

veloren's build depends on vek 0.11.2 and 0.12.0, but the flatpak only downloads 0.11.2

Flatpak downloads both version as specified in Cargo.lock - I guess otherwise cargo --offline fetch would've failed.

tim77 commented 3 years ago

This could caused by rust-nightly daily flathub updates. That's why i wanted to stick with synced Veloren rust-nightly toolchain. Seems like Veloren the only one project using rust-nighly at this moment on Flathub.

gasinvein commented 3 years ago

Maybe just bundle whatever rust nightly version they're using, if it doesn't build with the latest? I think we can peek into their CI files and automate following their rust-nightly version.

BryanQuigley commented 3 years ago

some changes just got made around vek - so maybe it would work now?

BryanQuigley commented 3 years ago

Nope, I was wrong, the vek update didn't fix it.

I'm building successfully from Veloren git with rustc 1.50.0 - so I tried the flatpak build with rust-stable (seems to 1.50 https://github.com/flathub/org.freedesktop.Sdk.Extension.rust-stable/commit/a1f59b57dddc42dfeac13e8c3a09f610917acf74) but still no luck.