search

flathub / org.atheme.audacious

https://flathub.org/apps/details/org.atheme.audacious
5 stars 4 forks source link

Drag and Drop from non-Music folder doesn't work #5

Closed ramesh45345 closed 4 years ago

ramesh45345 commented 4 years ago

I believe the current flatpak permissions don't allow for dragging and dropping songs into the playlist to work (at least from Gnome Files on the Gnome Desktop, Fedora 32 x86_64, flatpak v1.8.2).

Steps to reproduce:

  1. Open the Audacious flatpak.
  2. Drag an mp3 file from the home folder (or anywhere really) into the playlist.
  3. Observe that the error "Error playing file:///\<home folder>/test.mp3: No such file or directory" is generated.

This also manifests in such a way that when you open Audacious, and try to play the previous playlist, you will get the same error.

I compared the permissions to the VLC flatpak, where this currently works, and VLC has the "filesystems=host" permission, in addition to other miscellaneous filesystem accesses. I think this would be good to enable "filesystems=host" in the Audacious flatpak, just because music anywhere in the filesystem (not just the home folder, but in /mnt, /media, etc) could be accessed. If there are access concerns, host can be set to ro, however VLC doesn't seem to do this (likely for editing metadata and other things), so its probably fine to have it be rw.

As a workaround, this permission can be granted to the flatpak using sudo flatpak override --filesystem=host org.atheme.audacious, and reset/reverted to its original settings using sudo flatpak override --reset org.atheme.audacious. When allowing host, the above behavior/problem is fixed.

tim77 commented 4 years ago

Drag and Drop from Gnome Files doesn't work

Title is misleading, Drag and Drop from non-Music folder doesn't work and it shouldn't work obviously.

--filesystem=host

This discussed so many times. It's not only unsafe and insecure this will also leads to non reproducible bugs. Only minimum should allowed by default to run app successfully. If user want to extend and allow more things it could do this via Flatseal app or via console at least. Elementary already implemented this in their Settings, GNOME wanted to add this as well in their gnome-control-center. Nothing prevent this implement in KDE or any other DE. But no need to force every user allowing host file system.

in /mnt, /media

This is good point. /mnt used for permanent mounts usually, but /media is a place for dynamical storage's. I think we should add and allow by default --filesystem=/media:ro and --filesystem=/run/media:ro.