Fix the appdata file - Githubissues

flathub / org.blender.Blender

https://flathub.org/apps/details/org.blender.Blender

18 stars 26 forks source link

Fix the appdata file #13

Closed bochecha closed 6 years ago

bochecha commented 6 years ago

@TingPing pointed out our appdata file is incorrect on a few levels:

it uses the old format
it points to blender.desktop which gets renamed during the build
it is missing a launchable tag

We should fix it.

Unfortunately the upstream one, while better, is also incorrect:

<launchable type="desktop" should be <launchable type="desktop-id" (docs)
the launchable id needs to be renamed to org.blender.Blender.desktop

cc-ing @PointedStick who sent the appdata file upstream

TingPing commented 6 years ago

it uses the old format

appstream-util upgrade btw.

Pointedstick commented 6 years ago

I don't think the launchable ID can be org.blender.Blender.desktop because that's not the name of their desktop file. It's still blender.desktop.

bochecha commented 6 years ago

I don't think the launchable ID can be org.blender.Blender.desktop because that's not the name of their desktop file. It's still blender.desktop.

But it needs to be in the Flatpak build. Whether that goes upstream or not is a different question of course, but this being the bug tracker for the Flatpak build, I'm writing down here what I need to do for the Flatpak build. :wink:

Pointedstick commented 6 years ago

Submitted a fix for the launchable tag upstream: https://developer.blender.org/D3065#72995

Renaming their desktop file is on my to-do list, but I'm trying to build trust and confidence over time rather than doing too much at once and getting shut down.

bochecha commented 6 years ago

Renaming their desktop file is on my to-do list, but I'm trying to build trust and confidence over time rather than doing too much at once and getting shut down.

That's fine. Thank you for doing this. :slightly_smiling_face: