search

flathub / org.blender.Blender

https://flathub.org/apps/details/org.blender.Blender
17 stars 26 forks source link

Build opensubdiv #25

Closed vjar closed 5 years ago

vjar commented 5 years ago

The subsurf and multires modifiers appeared to not function with the beta version, which do work with these changes. The discussion at [1] suggests opensubdiv is missing from the build.

While WITH_OPENSUBDIV is indeed set in the config-opts of blender in the build manifest, I believe it is ignored due to similar reasons discussed by @bochecha here[2].

[1] https://developer.blender.org/T62693 [2] https://github.com/flathub/org.blender.Blender/issues/3#issuecomment-366451031

flathubbot commented 5 years ago

Started test build 2011

flathubbot commented 5 years ago

Build 2011 successful To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/1920/org.blender.Blender.flatpakref
bochecha commented 5 years ago

Hi, thanks for this change.

I was sure I had done it some time ago when I realized this was missing, but apparently I forgot, so I'm very glad you picked it up and made it happen. :slightly_smiling_face:

I currently don't have a computer so I can't test this… can you verify that the test build works properly and does enable the OpenSubdiv stuff? (see the comment from @flathubbot above for instructions)

I only have two minor nitpicks, otherwise this looks good to go.

vjar commented 5 years ago

Should be good now.

I can confirm subdivision works in the test build for me.

flathubbot commented 5 years ago

Started test build 2096

flathubbot commented 5 years ago

Build 2096 successful To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/2006/org.blender.Blender.flatpakref
bochecha commented 5 years ago

Thanks for the fixups and for confirming this does fix the issue! :+1: