search

flathub / org.bluej.BlueJ

https://flathub.org/apps/details/org.bluej.BlueJ
0 stars 5 forks source link

License identifiers break all builds #2

Closed jess-sch closed 5 years ago

jess-sch commented 5 years ago

SPDX updated the spec and deprecated the old license names, so they're not accepted anymore by appdata validation. If anyone knows how to use the WITH operator in appdata, please tell me.

TingPing commented 5 years ago

Hmm, it looked like your usage was correct: GPL-2.0-only WITH Classpath-exception-2.0.

CC @hughsie

hughsie commented 5 years ago

It's GPL-2.0-with-classpath-exception -- we can't break API to support the new names without updating soname and getting ~800 upstream projects to change the deprecated syntax. It was a dumb move for the SPDX to change the format like they did.

jess-sch commented 5 years ago

It's GPL-2.0-with-classpath-exception

It isn't though. I was initially using this but I changed it because the appdata validation failed the build process.

builddir/files/share/appdata/org.bluej.BlueJ.appdata.xml: FAILED:
• tag-invalid           : <metadata_license> is not valid [GPL-2.0-with-classpath-exception]
Validation of files failed
program finished with exit code 1

I suspect someone updated the list of valid license IDs without considering that exceptions require special syntax - or it checks the existence with an HTTP request, failing when it 404s or gets a deprecation notice.

hughsie commented 5 years ago

Right, GPL-2.0-with-classpath-exception is a valid project licence. It's not a valid metadata license. The metadata licence has to be an acceptable content licence, not a licence designed for code. There's a listed subset in the docs of acceptable content licences.

jess-sch commented 5 years ago

... but the metadata has explicitly been released under the GPL by upstream. What should I do in this case? Back when I first submitted the flatpak, this was accepted.

hughsie commented 5 years ago

What should I do in this case

Ask them to use one of the approved metadata licenses: https://www.freedesktop.org/software/appstream/docs/chap-Metadata.html#tag-metadata_license