flathub / org.chromium.Chromium

https://flathub.org/apps/details/org.chromium.Chromium
43 stars 25 forks source link

Add chromium-wayland-vaapi patches #343

Closed EliasTheGrandMasterOfMistakes closed 7 months ago

flathubbot commented 8 months ago

Started test build 89169

flathubbot commented 8 months ago

Build 89169 successful To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/71847/org.chromium.Chromium.flatpakref
flathubbot commented 8 months ago

Started test build 89494

flathubbot commented 8 months ago

Build 89494 successful To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/72176/org.chromium.Chromium.flatpakref
flathubbot commented 8 months ago

Started test build 89540

flathubbot commented 8 months ago

Build 89540 successful To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/72222/org.chromium.Chromium.flatpakref
flathubbot commented 8 months ago

Started test build 91091

EliasTheGrandMasterOfMistakes commented 8 months ago

Sorry for the commits name if this build works, i will rebase and rename commits and remove the DO NOT MERGE commit

EliasTheGrandMasterOfMistakes commented 8 months ago

i think this commit makes nothing difference, can be hard to build using systemside ffmpeg libraries, in this case will be necessary to add ffmpeg-full extensions and fedora team patches for build using system side shared ffmpeg, one day i will try this

flathubbot commented 8 months ago

Build 91091 successful To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/73771/org.chromium.Chromium.flatpakref
flathubbot commented 8 months ago

Started test build 91208

EliasTheGrandMasterOfMistakes commented 8 months ago

image this needs to work, why good WHY!!!!

flathubbot commented 8 months ago

Build 91208 failed

EliasTheGrandMasterOfMistakes commented 8 months ago

is necessary to rebase this patch, i will try after buy a new hd because chromium repo is much bigger

EliasTheGrandMasterOfMistakes commented 8 months ago

i'm just in a minimalist ssd. Is looks impossible to clone and try to cherry-pick sadly, i will try to view if rmader can rebase this if are possible

flathubbot commented 8 months ago

Started test build 91309

flathubbot commented 8 months ago

Build 91309 successful To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/73989/org.chromium.Chromium.flatpakref
flathubbot commented 8 months ago

Started test build 91513

flathubbot commented 8 months ago

Build 91513 failed

flathubbot commented 8 months ago

Started test build 91560

flathubbot commented 8 months ago

Build 91560 successful To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/74244/org.chromium.Chromium.flatpakref
EliasTheGrandMasterOfMistakes commented 8 months ago

Is building but in my igpu not working, idk if in new igpu is working, is necessary some testing with ozone platform wayland -enable-features=VaapiVideoDecodeLinuxGL is the new flag for vaapi in opengl backend

flathubbot commented 8 months ago

Started test build 91934

flathubbot commented 8 months ago

Build 91934 failed

flathubbot commented 7 months ago

Started test build 94524

flathubbot commented 7 months ago

Build 94524 failed

flathubbot commented 7 months ago

Started test build 94562

flathubbot commented 7 months ago

Build 94562 successful To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/77310/org.chromium.Chromium.flatpakref
flathubbot commented 7 months ago

Started test build 96759

flathubbot commented 7 months ago

Build 96759 successful To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/79520/org.chromium.Chromium.flatpakref
flathubbot commented 7 months ago

Started test build 98012

flathubbot commented 7 months ago

Build 98012 successful To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/80786/org.chromium.Chromium.flatpakref
ninja- commented 7 months ago

bot, build

flathubbot commented 7 months ago

Queued test build for org.chromium.Chromium.

ninja- commented 7 months ago

I'll be happy to test this for you with AMD and unpatched mesa :) in the meantime, can we get maintainers perspective on merging this? New Chromium will be released soon, but I believe you only then need to drop one commit that was pulled 1:1 into Chromium lately. The rest of patches are still relevant for Wayland to work and work with unpatched mesa

bbhtt commented 7 months ago

Why are you queuing builds? Chromium takes over 3 hours to build on Flathub

ninja- commented 7 months ago

The build expired:

➜ ~ flatpak install --user https://dl.flathub.org/build-repo/80786/org.chromium.Chromium.flatpakref błąd: Can't load uri https://dl.flathub.org/build-repo/80786/org.chromium.Chromium.flatpakref: Server returned status 404

I believe these test builds have limited lifetime

flathubbot commented 7 months ago

Started test build 100129

Erick555 commented 7 months ago

in the meantime, can we get maintainers perspective on merging this?

I think maintainer shared their perspective on this before. This is n-th time similar PR is submitted here.

flathubbot commented 7 months ago

Build 100129 failed

EliasTheGrandMasterOfMistakes commented 7 months ago

I'll be happy to test this for you with AMD and unpatched mesa :) in the meantime, can we get maintainers perspective on merging this? New Chromium will be released soon, but I believe you only then need to drop one commit that was pulled 1:1 into Chromium lately. The rest of patches are still relevant for Wayland to work and work with unpatched mesa

Sadly this looks not works well in RadeonSI VAAPI driver and doens't works i965 VAAPI driver, sadly VAAPI for chromium works on top multiplanar formats and have amount of problems. The official maintainer looks not have plans to merge it, and Chromium is already merging some necessary patches, i think in the next release VAAPI will work in AMD and intel olders gpus

EliasTheGrandMasterOfMistakes commented 7 months ago

I'm closing, this patches just working in newest intel GPUs and can't work in AMD, the lastest patch for enable ozone wayland in build is already in upstream, is just a little time question to all others patches will be merged too.

ninja- commented 6 months ago

is just a little time question to all others patches will be merged too.

I doubt that, Google has no intention of fixing VA-API on Wayland and it will probably stay broken for nearest future. Maintainers of different package system will have more or less intention to maintain the right patches going forward.

Sadly this looks not works well in RadeonSI VAAPI driver and doens't works i965 VAAPI driver, sadly VAAPI for chromium works on top multiplanar formats and have amount of problems.

I thought that giga patch for disjoint VAAPI fixed that?

ninja- commented 6 months ago

Chrome 122 was released 2 days ago so that's a good time to review the patches(either at this flatpak or in another fork :) ). Maybe your work could live under another maintainers, say, Ungoogled Chromium?

The last missing patch btw. for perfect setup is Vulkan Wayland support, which is stuck somewhere here https://issues.chromium.org/issues/41392107 since 2020