search

flathub / org.chromium.Chromium

https://flathub.org/apps/details/org.chromium.Chromium
43 stars 25 forks source link

yml: Set VK Driver and Layers Env variables #369

Closed EliasTheGrandMasterOfMistakes closed 5 months ago

EliasTheGrandMasterOfMistakes commented 5 months ago

VK_ADD_LAYER_PATH defines where is path who contains the vk layers. VK_ADD_DRIVER_FILES defines where can find vulkan drivers icd.d files.

This can be use in future for others flathub chromium's based packages

flathubbot commented 5 months ago

Started test build 105834

EliasTheGrandMasterOfMistakes commented 5 months ago

someone can cancel the build? is not necessary is just a env var, you can set in flatpak and test in your actual browser.

This fixes vk icd search on Angle Vulkan Backend and allow to use Vulkan Backend without problems

@ebassi @refi64

Erick555 commented 5 months ago

If you expect this to be merged then it must pass the build. BTW: should the fix be done on runtime level?

EliasTheGrandMasterOfMistakes commented 5 months ago

If you expect this to be merged then it must pass the build. BTW: should the fix be done on runtime level?

Yes is just a env var, is possible to define this two env var in your chromium and testing, this allow to chromium uses the layers and icds from drivers, this fix the problem about vulkan drivers not be found by chromium and allow to use angle vulkan renderer and vulkan capabilities

flathubbot commented 5 months ago

Build 105834 successful To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/88641/org.chromium.Chromium.flatpakref
EliasTheGrandMasterOfMistakes commented 5 months ago

On my system this fix problems nothing Vulkan ICD is detected by vulkan loader. IDK if this affects others users, but ungoogledchromium looks have a issue about it

flathubbot commented 5 months ago

Started test build 106777

EliasTheGrandMasterOfMistakes commented 5 months ago

if is necessary i will send a print about the result with and without this envs

flathubbot commented 5 months ago

Build 106777 successful To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/89596/org.chromium.Chromium.flatpakref
EliasTheGrandMasterOfMistakes commented 5 months ago

Sorry others people have confirmed this bug in a telegram group exist in chromium and ungoogled chromium, if is necessary i will send this pr first to ungoogled chromium for a test

rany2 commented 5 months ago

We also build for ARM64, this has be done in some other way.

refi64 commented 5 months ago

Yeah hardcoding it as x64 isn't gonna really work here.