search

flathub / org.chromium.Chromium

https://flathub.org/apps/details/org.chromium.Chromium
43 stars 25 forks source link

Make vulkan driver visible to chrome(ium) #376

Closed rainDiX closed 5 months ago

rainDiX commented 5 months ago

I was trying to play with WebGPU in chromium and noticed that anything vulkan was not working. Thankfully, I stumbled upon this comment https://github.com/flatpak/flatpak/issues/5131#issuecomment-1947245971

TL;DR chrome(ium) vendors libvulkan, so it does not contains the patch that search the correct path for drivers, so this patch set the VK_DRIVER_FILES variable.

I think this should also be applied to the other chromium-based browser on flathub, so far I tested chromium and ungoogled-chromium.

flathubbot commented 5 months ago

Started test build 108233

rainDiX commented 5 months ago

I just saw #369, and I think this approach is better since it also works on ARM

flathubbot commented 5 months ago

Build 108233 successful To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/91053/org.chromium.Chromium.flatpakref
refi64 commented 5 months ago

If this is something that other Chrome variants can also use, it might be better inside cobalt which is what's responsible for starting all those browsers. In particular it should be possible to largely copy-paste the existing code that does this for the libgl drivers path (setting this shouldn't be needed in the startup script here too, I think I just forgot to clean that up?). If you want you can try to PR it, or I can just push a commit for it and link back to this PR for credit purposes?

rainDiX commented 5 months ago

@refi64 you can push a commit that's fine by me.