search

flathub / org.clementine_player.Clementine

https://flathub.org/apps/details/org.clementine_player.Clementine
3 stars 6 forks source link

Spotify binary blob broken #26

Open ntninja opened 5 years ago

ntninja commented 5 years ago

Having access to a Spotify account, I was curious what adding it to Clementine would do. (Spoiler: If you expect any kind of “integration” you'll be quite disappointed.) However when, after downloading the proprietary Spotify extension, logging in, it would just never complete but rather stay in a broken state until you restart Clementine.

Digging a bit I found this to be because the downloaded binary requires two Qt4 libraries to be present, in particular these are: libQtCore.so.4 and libQtNetwork.so.4. ¹

Please kindly add a minimal Qt4 build with just these two libraries, so that this feature will work out-of-the-box for people wanting to use it.

¹ Additionally the libraries libgstreamer-10.so, libgobject-2.0.so, libgstapp-1.0.so.0, libstdc++.so.6 and glibc are required by the blob, but these are already part of the image so no problems there.

FakeShemp commented 4 years ago

I don't think the Spotify library can be included in the app since it's proprietary. This will probably need to be an extension or plugin.

ntninja commented 4 years ago

@FakeShemp: Clementine already has a built-in downloader for the Spotify library that explicitly warns about it on being an untrusted binary extension. This issue isn't about including Spotify, it is about including the minimal required runtime environment used by that existing Spotify extension.

hoshsadiq commented 4 years ago

@FakeShemp any more thoughts after @ntninja's comment? It seems the relevant dependencies aren't available so when the Spotify plugin is installed through Clementine, the plugin doesn't work.

According to https://github.com/clementine-player/clementine/issues/3930 libproto9 needs to be installed too.

FakeShemp commented 4 years ago

Pull requests are welcome.

On Sun, Nov 1, 2020, 16:57 Hosh notifications@github.com wrote:

@FakeShemp https://github.com/FakeShemp any more thoughts after @ntninja https://github.com/ntninja's comment? It seems the relevant dependencies aren't available so when the Spotify plugin is installed through Clementine, the plugin doesn't work.

According to clementine-player/Clementine#3930 https://github.com/clementine-player/Clementine/issues/3930 libproto9 needs to be installed too.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/flathub/org.clementine_player.Clementine/issues/26#issuecomment-720110198, or unsubscribe https://github.com/notifications/unsubscribe-auth/AB4VNLY56NNHZOLBPX4LZV3SNWAPPANCNFSM4JA5XNIQ .