search

flathub / org.darktable.Darktable

https://flathub.org/apps/details/org.darktable.Darktable
5 stars 14 forks source link

Keep dependencies up to date #100

Closed g2p closed 1 month ago

g2p commented 1 year ago

This adds flatpak-external-data-checker metadata to keep dependencies automatically up to date.

Most of them are updated, except GMIC due to build system issues.

Motivated by https://github.com/darktable-org/darktable/issues/13306, a bug when the libheif dependency is below 1.13.0.

flathubbot commented 1 year ago

Started test build 16331

flathubbot commented 1 year ago

Build 16331 successful To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/128759/org.darktable.Darktable.flatpakref
flathubbot commented 1 year ago

Started test build 16412

flathubbot commented 1 year ago

Build 16412 successful To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/128844/org.darktable.Darktable.flatpakref
paperdigits commented 1 year ago

G'MIC should be built using plain old make now.

paperdigits commented 1 year ago

Can you link to something that details this automatic upgrade thing? I might be old now, but I like named versions with their hashes.

hfiguiere commented 1 year ago

https://github.com/flathub/flatpak-external-data-checker

But the bot will just submit a PR with the changes.

paperdigits commented 1 year ago

oh, interesting. thanks.

g2p commented 1 year ago

Ping? This would have prevented #102

flathubbot commented 1 year ago

Started test build 33389

flathubbot commented 1 year ago

Build 33389 failed

flathubbot commented 1 year ago

Started test build 33395

flathubbot commented 1 year ago

Build 33395 failed

flathubbot commented 1 year ago

Started test build 33396

flathubbot commented 1 year ago

Build 33396 successful To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/16030/org.darktable.Darktable.flatpakref
hfiguiere commented 1 year ago

Ping? This would have prevented #102

not it wouldnt have. it would just have caused random failures unsupervised.

g2p commented 1 year ago

Why would anything be left unsupervised?

Anyway, the motivation was the bug I linked at the top of the PR: there was an issue with older versions of libheif (which provides HEIC support). Sticking to the unfixed version was the cause of #102.

flathubbot commented 1 year ago

Started test build 33533

flathubbot commented 1 year ago

Build 33533 successful To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/16167/org.darktable.Darktable.flatpakref
hfiguiere commented 1 year ago

Why would anything be left unsupervised?

Anyway, the motivation was the bug I linked at the top of the PR: there was an issue with older versions of libheif (which provides HEIC support). Sticking to the unfixed version was the cause of #102.

So instead of just fixing the bug you do a large PR with lot of stuff the maintainers aren't keen on. Understood.

Had the PR been titled "fix HEIF support" or something directly related it would have been clearly visible.

I personally tend to ignore any PR that add f-e-d-c (or outwardly reject them).