search

flathub / org.darktable.Darktable

https://flathub.org/apps/details/org.darktable.Darktable
5 stars 14 forks source link

Missing AVIF export in darktable 4.6.0 #118

Closed kadykov closed 8 months ago

kadykov commented 8 months ago

Describe the bug

In the export module the export in the AVIF format is missing. In darktable 4.4.2 this option was present and it was working great.

Steps to reproduce

In darkroom or in lighttable open export module and try to find AVIF format export.

Expected behavior

AVIF format export should be available

Logfile | Screenshot | Screencast

Screenshot from 2024-01-04 15-15-30

Where did you obtain darktable from?

Flatpak from flathub

darktable version

4.6.0

What OS are you using?

Linux

What is the version of your OS?

Fedora Silverblue 39

Describe your system?

All the images are in a NFS storage.

System Details Report

Report details
Hardware Information:
Software Information:

This issue was also posted in general darktable issues

hfiguiere commented 8 months ago

it's probably related to https://github.com/flathub/org.darktable.Darktable/pull/117#issuecomment-1870760390

kmilos commented 8 months ago

it's probably related to https://github.com/flathub/org.darktable.Darktable/pull/117#issuecomment-1870760390

Don't think so.

Please keep up w/ the release notes when packaging - the "Changed Dependencies" section does mention libavif requirement was bumped to at least 0.9.2.

hfiguiere commented 8 months ago

the build system didn't check the specific version. It's 0.9.1...

kmilos commented 8 months ago

The build system could indeed be improved to fail hard if the requested feature is not exactly satisfied (WIP: https://github.com/darktable-org/darktable/issues/15803)...

Still, the release notes (and the list of dependencies on the project README) should be clear and helpful enough for packagers to follow.

hfiguiere commented 8 months ago

does mention libavif requirement was bumped to at least 0.9.2.

Except that this doesn't fix it. So there.

kmilos commented 7 months ago

Except that this doesn't fix it.

Ah... Turns out the libavif 0.9.2 tag/tarball was still reporting itself as 0.9.1! https://github.com/AOMediaCodec/libavif/blob/v0.9.2/CMakeLists.txt#L10

I might as well bump the docs/cmake to 0.9.3 then...