search

flathub / org.darktable.Darktable

https://flathub.org/apps/details/org.darktable.Darktable
5 stars 14 forks source link

Added libusb. (Issue #4) #24

Closed hfiguiere closed 5 years ago

hfiguiere commented 5 years ago

OBSOLETE caveat: you have to run with --device=all

flathubbot commented 5 years ago

NOTE: This comment was posted by the test instance of buildbot

Started test build 678

flathubbot commented 5 years ago

NOTE: This comment was posted by the test instance of buildbot

Build 678 successful To test this build, install it from the testing repository:

flatpak install --user http://repo-test.flathub.org:8080/build-repo/628/org.darktable.Darktable.flatpakref
jurf commented 5 years ago

@hfiguiere if it won’t work without --device=all, just add it.

hfiguiere commented 5 years ago

I was standing on the cautious side to not give to much permission. If that's ok, I can do that.

flathubbot commented 5 years ago

NOTE: This comment was posted by the test instance of buildbot

Started test build 691

flathubbot commented 5 years ago

NOTE: This comment was posted by the test instance of buildbot

Build 691 successful To test this build, install it from the testing repository:

flatpak install --user http://repo-test.flathub.org:8080/build-repo/639/org.darktable.Darktable.flatpakref
w-wagner commented 5 years ago

I would like to confirm, that the test build 639 above fixes my issue #26 The option "--device=all" does not help to find the camera. The build 639 fixes my issues and makes darktable work as usual. I will use this test build to check for other issues. Good work! Thanks for the patch! Please merge, if there appear no other new issues!

jurf commented 5 years ago

The option "--device=all" does not help to find the camera.

What’s the context here? In the regular build it won’t help, because it misses libusb, but this PR already includes --device=all by default.

w-wagner commented 5 years ago

Yes right. I was in a discussion with Hubert Figuière whether --device=all will make the release work or not. Maybe this all is a misunderstanding... The main point is: My tests confirm that this patch works and solves my issue In the meantime I am working with the testbuild. I have found no other issues yet.

hfiguiere commented 5 years ago

Just to reiterate: with that PR you shouldn't have to add --device=all as launch time because it's in the manifest. Originally I didn't add it because I was being cautious to not add broad permissions, but then I updated the PR.

If it doesn't work out of the box, let me know.

hfiguiere commented 5 years ago

Superceded by PR #28