search

flathub / org.darktable.Darktable

https://flathub.org/apps/details/org.darktable.Darktable
5 stars 14 forks source link

Add Lua support. Fixes #35. #36

Closed paperdigits closed 5 years ago

paperdigits commented 5 years ago

Use flathub's shared modules to add lua support.

flathubbot commented 5 years ago

Started test build 3268

flathubbot commented 5 years ago

Build 3268 failed

flathubbot commented 5 years ago

Started test build 3271

flathubbot commented 5 years ago

Build 3271 failed

matze commented 5 years ago

Could you rebase against master to pick up your other merged change?

flathubbot commented 5 years ago

Started test build 3314

flathubbot commented 5 years ago

Build 3314 failed

paperdigits commented 5 years ago

Well those build failures are annoying. I guess I will try to send some patches upstream to darktable.

paperdigits commented 5 years ago

@matze should we patch the AppData file with the info so the build we succeed again?

matze commented 5 years ago

Sure, if you want to you can add another commit here. Otherwise I can spent a few minutes later tonight.

paperdigits commented 5 years ago

@matze I'd appreciate if you could do it. I'm not sure exactly which file to patch.

flathubbot commented 5 years ago

Started test build 5824

flathubbot commented 5 years ago

Build 5824 failed

paperdigits commented 5 years ago

@matze I'm not sure what I did wrong. I think the patch is getting applied after make is run in DT? I'm not sure.

matze commented 5 years ago

Forgot about this PR here. I added release data with the last commits, so could you update this branch here by removing the last commit and rebasing the Lua one on top of master?

flathubbot commented 5 years ago

Started test build 6540

paperdigits commented 5 years ago

@matze done! Thank you for patching in the AppData stuff.

flathubbot commented 5 years ago

Build 6540 successful To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/6267/org.darktable.Darktable.flatpakref
matze commented 5 years ago

Likewise, thanks for adding Lua support ;-)