flathub / org.darktable.Darktable

https://flathub.org/apps/details/org.darktable.Darktable
5 stars 14 forks source link

appdata: fix release #45

Closed eszlari closed 4 years ago

eszlari commented 4 years ago

https://flathub.org/apps/details/org.darktable.Darktable still shows 2.6.2

flathubbot commented 4 years ago

Started test build 11259

flathubbot commented 4 years ago

Build 11259 failed

hfiguiere commented 4 years ago
  1. patch is malformed, hence build failure
  2. release should just be added. your patch attempt to remove the previous one.
eszlari commented 4 years ago

How about this solution:

https://github.com/flathub/org.kde.okular/blob/e7c81da6a0061b6e4c969533d8b464e7186af28a/org.kde.okular.json#L315

This is easier to edit from the Github UI.

hfiguiere commented 4 years ago

Also I don't see why this is happening. Looks like the page should have been updated.

eszlari commented 4 years ago

You have two top-level <releases> tags.

flathubbot commented 4 years ago

Started test build 11263

eszlari commented 4 years ago

I'm planing on submitting a patch like this upstream:

https://github.com/obsproject/obs-studio/commit/6b9da9b9127f066e782d0fe8be5cc703da570d1f

Then the release entry will always be up to date.

flathubbot commented 4 years ago

Build 11263 successful To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/10733/org.darktable.Darktable.flatpakref
flathubbot commented 4 years ago

Started test build 11266

flathubbot commented 4 years ago

Build 11266 successful To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/10735/org.darktable.Darktable.flatpakref
hfiguiere commented 4 years ago

You have two top-level <releases> tags.

Oops. Seriously I missed that. Now the drastic appstream util validate didn't catch that either.

hfiguiere commented 4 years ago

Sorry this is too cryptic as a solution.

If you want to submit to upstream something that will update the appdata file automatically, feel free.

I have pushed a patch to fix this issue here.